From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwsMF-0001N3-9Y for qemu-devel@nongnu.org; Tue, 17 Jun 2014 08:19:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwsM9-0002Hz-IL for qemu-devel@nongnu.org; Tue, 17 Jun 2014 08:19:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwsM8-0002Gt-UL for qemu-devel@nongnu.org; Tue, 17 Jun 2014 08:19:17 -0400 Message-ID: <53A03241.8090106@redhat.com> Date: Tue, 17 Jun 2014 06:19:13 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EV7cAAoQtH47IqapMD5WSernS9H15UNlI" Subject: Re: [Qemu-devel] [PATCH v5 00/10] Modify block jobs to use node-names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, benoit.canet@irqsave.net, pkrempa@redhat.com, famz@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EV7cAAoQtH47IqapMD5WSernS9H15UNlI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/13/2014 12:52 PM, Jeff Cody wrote: > Changes from v4->v5: >=20 > * Rebased on master > * Fixed commit log typos / stale paragraphs (Eric) > * Fixed comment typo (Eric) > * Added Eric's remaining R-b's >=20 On IRC, we found another bug that needs repairing: # cd /tmp # echo tmp > tmp # qemu-kvm -qmp stdio -drive file=3D/tmp/tmp {"QMP": {"version": {"qemu": {"micro": 50, "minor": 0, "major": 2}, "package": ""}, "capabilities": []}} {"execute":"qmp_capabilities"} {"return": {}} {"execute":"block-commit","arguments":{"device":"ide0-hd0"}} {"return": {}} {"timestamp": {"seconds": 1402972048, "microseconds": 153175}, "event": "BLOCK_JOB_READY", "data": {"device": "ide0-hd0", "len": 512, "offset": 512, "speed": 0, "type": "commit"}} {"execute":"block-job-complete","arguments":{"device":"ide0-hd0"}} {"return": {}} qemu-system-x86_64: block.c:2034: bdrv_swap: Assertion `bs_new->device_name[0] =3D=3D '\0'' failed. Aborted (core dumped) Attempts to commit-to-self should be rejected at block-commit time, rather than causing an assertion failure down the road. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EV7cAAoQtH47IqapMD5WSernS9H15UNlI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJToDJBAAoJEKeha0olJ0NqhWwH/j4zI9PACPrVShIoOSAUryWs CTbpyRveOl1zJo8pNH05C2TXqtR86oDkfSade1XOJMNt+Yyj6/ZqzCXFG8YaIOnX vTWO8k0uvD+EjwofBh1rIB1lLSWfAH33O5qXQjrEWXdpHMZXAVuWnBg1OGpGtRJT Mkz+S0joTf4qjJdJaJjw/vqWBlsA7obAsfswAS3henKfRlDTmCPBrCRDMHcRO1UJ 1DtAyw0ApBNiQSoqro1XQLhH7lSAJBUBPhwXjwEytqlMLAUGkk9S7PUT+21oZjgE u6X+utC223YEMOCi1eNadrjHtlqhM9wEweGELW3r6ghj8sqPJW8U2wlmzu/MMA8= =UpTo -----END PGP SIGNATURE----- --EV7cAAoQtH47IqapMD5WSernS9H15UNlI--