From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwsc7-0000vP-BU for qemu-devel@nongnu.org; Tue, 17 Jun 2014 08:35:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wwsbx-0007rQ-Qv for qemu-devel@nongnu.org; Tue, 17 Jun 2014 08:35:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27005) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwsbx-0007rI-Hk for qemu-devel@nongnu.org; Tue, 17 Jun 2014 08:35:37 -0400 Message-ID: <53A03615.7040701@redhat.com> Date: Tue, 17 Jun 2014 14:35:33 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1402489176-19738-1-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 00/13] "Light" memory region QOMification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: "qemu-devel@nongnu.org Developers" , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Il 17/06/2014 14:27, Peter Crosthwaite ha scritto: > This looks good to me, the only change I see worth making pre-merge is > moving object_property_add_child_array to the QOM core. All other > review discussions have been shelved or closed (as they are additive > suggestions mostly). What do you think of the idea of special-casing properties that end with "[*]" directly in object_property_add{,_full}? This would have to wait for 2.2, but these patches can go in 2.1 as well. I'll submit the series as soon as I get acks for the preliminary patches: libqtest; http://article.gmane.org/gmane.comp.emulators.qemu/279836 prop->resolve: http://article.gmane.org/gmane.comp.emulators.qemu/279594 Paolo