From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwtK9-0001R0-B2 for qemu-devel@nongnu.org; Tue, 17 Jun 2014 09:21:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwtK3-0007te-RQ for qemu-devel@nongnu.org; Tue, 17 Jun 2014 09:21:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwtK3-0007tT-Cx for qemu-devel@nongnu.org; Tue, 17 Jun 2014 09:21:11 -0400 Message-ID: <53A040C3.2060801@redhat.com> Date: Tue, 17 Jun 2014 07:21:07 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401970944-18735-1-git-send-email-wenchaoqemu@gmail.com> <1401970944-18735-18-git-send-email-wenchaoqemu@gmail.com> <539B7164.1030407@redhat.com> <53A00911.2090907@redhat.com> In-Reply-To: <53A00911.2090907@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QMxAjuP0rEhl8Ow4ul06BGwvxD8OcDWmS" Subject: Re: [Qemu-devel] [PATCH V6 17/29] qapi event: convert WATCHDOG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Wenchao Xia , qemu-devel@nongnu.org Cc: lcapitulino@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QMxAjuP0rEhl8Ow4ul06BGwvxD8OcDWmS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/17/2014 03:23 AM, Paolo Bonzini wrote: > Il 13/06/2014 23:47, Eric Blake ha scritto: >>> +## >>> > +# @WatchdogExpirationAction >> I think you will be better off to ensure that error.json is >> self-sufficient, perhaps by sticking any data type it references >> directly into common.json rather than qapi-schema.json, and having >> error.json include common.json. (This is the first instance of >> referencing an external type, but other events later in the series hav= e >> the same issue). >> >=20 > Can be done later though, I think? Yes; as I mentioned in my other mail: https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg03208.html This little exercise raises red flags for me - we probably ought to enhance the code generators to error out instead of blindly act as if unknown types are pointers. But save it for another day - no need to stall this series just to wait for a robustness improvement to the generators. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QMxAjuP0rEhl8Ow4ul06BGwvxD8OcDWmS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJToEDDAAoJEKeha0olJ0NqVu0IAIOy0mWt2PN9JdvMseeegJ32 omshWGz9zf6ek4KL2AMEzBtCn5DpieZCh0kRBZPD5B2s4Vyk77jQEvJo45Rqkho5 IuT2DgDln/osxUVK4kxzVr+nOlxJUSoHzSeWiFlZWntAKrAmWk8otHLpoP97mE5P tb7UGJL7/rCpilWiQflLFvZskfCcfNrhP61TomRJIPi4VsQbJ+Q+PbxpQOLOYJ7E gtgu9EnuDlpkaeTi0r77WzXvw9Or2mSlMRY3JPOfGs9JO+Kdcb5s/+DbEzeUMIdV SaDXJcJGXRO8K2oTcTsgjZMgA0e9m4R4p4hg9nqeyaCF/STc2QJU+PlN4JyQ0Gw= =gHtq -----END PGP SIGNATURE----- --QMxAjuP0rEhl8Ow4ul06BGwvxD8OcDWmS--