From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwtZd-0002tt-J2 for qemu-devel@nongnu.org; Tue, 17 Jun 2014 09:37:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwtZU-0007TU-V9 for qemu-devel@nongnu.org; Tue, 17 Jun 2014 09:37:17 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60568 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwtZU-0007TO-Pc for qemu-devel@nongnu.org; Tue, 17 Jun 2014 09:37:08 -0400 Message-ID: <53A04484.7030702@suse.de> Date: Tue, 17 Jun 2014 15:37:08 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1402065233-31894-1-git-send-email-akong@redhat.com> <20140609132251.GC19546@stefanha-thinkpad.redhat.com> <20140617125423.GG8709@z.redhat.com> In-Reply-To: <20140617125423.GG8709@z.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 0/4] test virtio-blk hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong , Stefan Hajnoczi Cc: arei.gonglei@huawei.com, qemu-devel@nongnu.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Amos, Am 17.06.2014 14:54, schrieb Amos Kong: > On Mon, Jun 09, 2014 at 03:22:51PM +0200, Stefan Hajnoczi wrote: >> On Fri, Jun 06, 2014 at 10:33:49PM +0800, Amos Kong wrote: >>> It's worth to add a hotplug test to qtest, but without=20 >>> cooperation of guest OS, new devices can't be initialized by >>> guest, and hot-unplug doesn't work. >>>=20 >>> However, the new test can cover some part of code of=20 >>> hotplug/unplug. >>>=20 >>> I will write another subtest to test hotplug with pci support. >>>=20 >>> V2: move qmp_exec_hmp_cmd() to libqtest.c excape hmp cmd >>> (stefanha) use qmp_exec_hmp_cmd() in blockdev-test V3: use >>> vp_list to format string, free escaped string V4: free escaped >>> string by g_free() >=20 > Hi Andreas, >=20 > Can you apply this patchset to your tree? Sorry for the late reply, I was on vacation and am still fighting a mail backlog... I had a question about the new HMP helper function - I see in 4/4 that drive_add was already being done via HMP, so I guess that's the culprit, but still I wonder whether we can do device-add via QMP. That said, I've reviewed the generic qtest part OK, and would assume virtio-blk-test (you can drop the .c in the topic please) to go through the same tree virtio-blk does, so via Stefan/Kevin. Regards, Andreas - --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJToESEAAoJEPou0S0+fgE/fbAP/Ainb27oOKTtkQwslqWeFWrq p/HS+IJ/mw1FJl7THu0lH9nUtSUhxf86sWa0zU1q7EYmc0Pl/ZqxZnK28R9ebsVg 5Fkij4Ze6nPwngbu8vOJ1DiI6yjxQfEteZpt3vS3ThtE8A1lC1iM5htiNdFsfCgj 08C7NR4+jQUGKZlSXtRYfdAR/LHyS7vtFscxCx4k4Erx3+R5hXbdFovkXz31PbJI rn439DeQTnkpBNmfr/S6S74WSKAwhZASOKN+d0jJ+RIjAqU/bFZEhE6LPsZ/MnVg GD2MZl+diLk44nr66BCK3Q/qiNS8rkSZ9UgvCo1SuwgSeo48f4MAtrEDfP0QS3Kz zo+nHkHtJlfWvbGC2US2xaHAaeQU/JpNa+dr5PBcM6Bwj5d1xQ2TVJmid7UzhZEC eB3KL5Za8gYIkzRBZqfH4cpiaABC8SFBu90ACmFMxRAydOqlK7fOXK761gGcaaif 1JJ0qk4InWG3PBR0N/YWX14nik5SdCsAcnjoulLuxSZ2HtJ3Rz3e4yII0qdjQsmB NMp9vLIVY+YlOwD2qzCS+4JOxkKlEF9fplsNwxelOKv28Ge2WCwcgiOySiVghUqn cVNpPrP7jgALFHMlnbQomyvT7Cu9GoF0ScJO3IpAXManSQ5j8BaDxkt3ZbwiT5kT ixvewd2AeNN9o/q1mZWq =3D9qZC -----END PGP SIGNATURE-----