From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45436)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Wwuth-0004zw-6F
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 11:02:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WwutZ-0006GQ-Np
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 11:02:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49872)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WwutZ-0006GI-GU
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 11:01:57 -0400
Message-ID: <53A0585E.5060701@redhat.com>
Date: Tue, 17 Jun 2014 17:01:50 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1402505369-12526-1-git-send-email-pbonzini@redhat.com>	<1402505369-12526-6-git-send-email-pbonzini@redhat.com>	<CAEgOgz4=xXAP23qYH9XJ3j1j9quz_KuxZUG1BoA6neQ9F_cwBQ@mail.gmail.com>	<53A04CD7.3080100@redhat.com>
	<CAEgOgz6Jb2BKqRSV9ZPr0GMecw1ZJZSsjpRQ-2KSvQHmmx2dxw@mail.gmail.com>
In-Reply-To: <CAEgOgz6Jb2BKqRSV9ZPr0GMecw1ZJZSsjpRQ-2KSvQHmmx2dxw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/5] mc146818rtc: add "rtc" link to
	"/machine"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Markus Armbruster <armbru@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>

Il 17/06/2014 16:25, Peter Crosthwaite ha scritto:
>> > &error_warn? :)  But then, /machine/rtc.tm is the only supported interface,
> I have thought about &error_warn in the past, but thought the better
> of it. Warnings need user digestable message and I can't think of a
> sane implementation where you populate a message for error framework
> to raise while maintaining the needed errp == NULL || *errp == NULL
> semantic at the same time.
>
>> > and it should be the same for all RTC devices so perhaps a NULL error
>> > pointer is enough.
>> >
> NULL Works for me. But other than source verbosity is there any reason
> to not catch the error?:

See above: it doesn't matter _which_ RTC gets the magic alias.  For a 
proper implementation, they should all be the same.

Paolo