From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48823)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Wwv7A-0000Gv-Jm
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 11:16:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Wwv70-0003ds-DW
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 11:16:00 -0400
Received: from cantor2.suse.de ([195.135.220.15]:34858 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Wwv70-0003dP-6l
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 11:15:50 -0400
Message-ID: <53A05BA4.8070800@suse.de>
Date: Tue, 17 Jun 2014 17:15:48 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1402505369-12526-1-git-send-email-pbonzini@redhat.com>	<1402505369-12526-2-git-send-email-pbonzini@redhat.com>
	<53A04E1C.5080105@suse.de>
In-Reply-To: <53A04E1C.5080105@suse.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/5] qom: add a generic mechanism to
 resolve paths
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: mtosatti@redhat.com, stefanha@redhat.com

Am 17.06.2014 16:18, schrieb Andreas F=E4rber:
> Am 11.06.2014 18:49, schrieb Paolo Bonzini:
>> diff --git a/qom/object.c b/qom/object.c
>> index e42b254..fcdd0da 100644
>> --- a/qom/object.c
>> +++ b/qom/object.c
[...]
>> @@ -1128,6 +1141,12 @@ static void object_set_link_property(Object *ob=
j, Visitor *v, void *opaque,
>>      }
>>  }
>> =20
>> +static Object *object_resolve_link_property(Object *parent, void *opa=
que, const gchar *part)
>> +{
>> +    LinkProperty *lprop =3D opaque;

Forgot: White line preferred even for single-line statements for
consistency.

>> +    return *lprop->child;
>> +}
>> +
>>  static void object_release_link_property(Object *obj, const char *nam=
e,
>>                                           void *opaque)
>>  {

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg