From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwvGJ-0004tl-15 for qemu-devel@nongnu.org; Tue, 17 Jun 2014 11:25:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwvGB-000706-Lv for qemu-devel@nongnu.org; Tue, 17 Jun 2014 11:25:26 -0400 Received: from qmta12.emeryville.ca.mail.comcast.net ([76.96.27.227]:60769) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwvGB-0006zo-Av for qemu-devel@nongnu.org; Tue, 17 Jun 2014 11:25:19 -0400 Message-ID: <53A05DD8.5070903@redhat.com> Date: Tue, 17 Jun 2014 09:25:12 -0600 From: Eric Blake MIME-Version: 1.0 References: <53A043CF.9030800@redhat.com> <20140617135917.GA24644@grmbl.mre> In-Reply-To: <20140617135917.GA24644@grmbl.mre> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nHXa0wNJ7iGidMrarECWH1lX567kQqTme" Subject: Re: [Qemu-devel] [PATCH v3 00/18] migration: add static analysis tool to check vmstate compat List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: Juan Quintela , qemu list , Markus Armbruster , Alexander Graf , Paolo Bonzini , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , "Dr. David Alan Gilbert" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nHXa0wNJ7iGidMrarECWH1lX567kQqTme Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/17/2014 07:59 AM, Amit Shah wrote: > On (Tue) 17 Jun 2014 [07:34:07], Eric Blake wrote: >> >> >> On 06/17/2014 07:19 AM, Amit Shah wrote: >>> Hello, >>> >>> v3: >>> - Python script returns an error code: 0 if no errors, positive for >>> the number of errors identified. >> >> Returning the error count as $? is unreliable - if you have exactly 25= 6 >> errors, that gives the same status as if you had success. Does your >> code guarantee non-zero return in that case? >=20 > No; any good ideas for this, then? Just limit to 255, and never bump > upwards? Yes, saturating math (capping at 255) is sufficient; in the normal case, we won't have that many errors. >=20 > I'm only introducing this so that future integration with 'make check' > can be noticed by scripts. And for that, all we need is a non-zero status. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nHXa0wNJ7iGidMrarECWH1lX567kQqTme Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJToF3YAAoJEKeha0olJ0NqdH4IAKLtFlJyV3HMGUs9xMVll5of e3bvubsctYW3309n3DPVXtE6IT4iKD5ajSvC04LJDguyvqmtJkjyTfWygOPQkR3/ bbOfo3MZrv4SwjmmDx88P/AL7LBdgfBGntvHNpOyAGthHf6TPoLzs997gof5p9GO lnsRqpnmn8kJ+6x1rEvU115YXcixiU+OPdmwdesWfNMfGrUHhfpguBxZDatY2ZgF TTtKqb0q7XTt+SXo/RVS93KgTWuT9RBp96bbFIbFpVhj4habZDsNzQMXjsQzY517 qPZqf3UR282O3T1xriXQSDc/yXfCFb0FTVmUchcQPGKjPbsDICNw1P0C1/c4lrU= =cfNQ -----END PGP SIGNATURE----- --nHXa0wNJ7iGidMrarECWH1lX567kQqTme--