From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Www5I-0006h9-Se for qemu-devel@nongnu.org; Tue, 17 Jun 2014 12:18:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Www5C-0000tB-25 for qemu-devel@nongnu.org; Tue, 17 Jun 2014 12:18:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Www5B-0000t7-QW for qemu-devel@nongnu.org; Tue, 17 Jun 2014 12:18:01 -0400 Message-ID: <53A06A2A.4070006@redhat.com> Date: Tue, 17 Jun 2014 18:17:46 +0200 From: Max Reitz MIME-Version: 1.0 References: <1402912857-10509-1-git-send-email-benoit.canet@irqsave.net> <1402912857-10509-5-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1402912857-10509-5-git-send-email-benoit.canet@irqsave.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v10 4/4] qemu-iotests: Add TestRepairQuorum to 041 to test drive-mirror node-name mode. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Beno=EEt_Canet?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Benoit Canet , stefanha@redhat.com On 16.06.2014 12:00, Beno=EEt Canet wrote: > The to-replace-node-name is designed to allow repairing a broken Quorum= file. > This patch introduces a new class TestRepairQuorum testing that the fea= ture > works. > Some further work will be done on QEMU to improve the robustness of the= tests. > > Signed-off-by: Benoit Canet > --- > tests/qemu-iotests/041 | 196 ++++++++++++++++++++++++++++++++++++= ++++++++- > tests/qemu-iotests/041.out | 4 +- > 2 files changed, 194 insertions(+), 6 deletions(-) The test looks fine in general and it does work, so I would give it a=20 reviewed-by. However, I still have some open questions from v9 about why=20 this test works, so I'll still wait. ;-) Max