From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwwWq-0006SV-Q6 for qemu-devel@nongnu.org; Tue, 17 Jun 2014 12:46:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwwWk-0002xa-L6 for qemu-devel@nongnu.org; Tue, 17 Jun 2014 12:46:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwwWk-0002xQ-Cf for qemu-devel@nongnu.org; Tue, 17 Jun 2014 12:46:30 -0400 Message-ID: <53A070E1.1050009@redhat.com> Date: Tue, 17 Jun 2014 18:46:25 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1402505369-12526-1-git-send-email-pbonzini@redhat.com> <1402505369-12526-4-git-send-email-pbonzini@redhat.com> <53A06EB7.8020801@suse.de> In-Reply-To: <53A06EB7.8020801@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/5] qom: allow creating an alias of a child<> property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Peter Crosthwaite Cc: Marcelo Tosatti , "qemu-devel@nongnu.org Developers" , Stefan Hajnoczi Il 17/06/2014 18:37, Andreas F=C3=A4rber ha scritto: >> > >> > Longer term, should "child" and "link" be macrofied and these >> > hardcoded strlen's be fixed to avoid difficult developer traps if >> > anyone ever tries to change the literal strings? > I think my preference would be a helper function that returns the T fro= m > link (non-dup'ed), which could then here be used as "link<%s>". How can you return it non-dup'ed? The trailing > gets in the way. For now I just used strlen("child"). Paolo