From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43834)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WwwYK-0007OF-S8
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 12:48:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WwwYD-0003YH-De
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 12:48:08 -0400
Received: from cantor2.suse.de ([195.135.220.15]:36976 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WwwYD-0003Y5-8D
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 12:48:01 -0400
Message-ID: <53A0713F.2010205@suse.de>
Date: Tue, 17 Jun 2014 18:47:59 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1402505369-12526-1-git-send-email-pbonzini@redhat.com>	<1402505369-12526-4-git-send-email-pbonzini@redhat.com>
	<CAEgOgz7=HDNbT5EaaDKO6HRVymnN3sU5sKqD82Qqj8shthVa9Q@mail.gmail.com>
	<53A06EB7.8020801@suse.de> <53A070E1.1050009@redhat.com>
In-Reply-To: <53A070E1.1050009@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 3/5] qom: allow creating an alias of a
 child<> property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Marcelo Tosatti <mtosatti@redhat.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

Am 17.06.2014 18:46, schrieb Paolo Bonzini:
> Il 17/06/2014 18:37, Andreas F=C3=A4rber ha scritto:
>>> >
>>> > Longer term, should "child" and "link" be macrofied and these
>>> > hardcoded strlen's be fixed to avoid difficult developer traps if
>>> > anyone ever tries to change the literal strings?
>> I think my preference would be a helper function that returns the T fr=
om
>> link<T> (non-dup'ed), which could then here be used as "link<%s>".
>=20
> How can you return it non-dup'ed?  The trailing > gets in the way.

Crap, didn't think of >.

> For now I just used strlen("child").

Works for me.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg