From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45794)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WwwfI-0004MV-Dg
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 12:55:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WwwfB-0006MT-84
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 12:55:20 -0400
Received: from cantor2.suse.de ([195.135.220.15]:37188 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WwwfB-0006Lw-1u
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 12:55:13 -0400
Message-ID: <53A072EF.10905@suse.de>
Date: Tue, 17 Jun 2014 18:55:11 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1402505369-12526-1-git-send-email-pbonzini@redhat.com>	<1402505369-12526-6-git-send-email-pbonzini@redhat.com>	<CAEgOgz4=xXAP23qYH9XJ3j1j9quz_KuxZUG1BoA6neQ9F_cwBQ@mail.gmail.com>	<53A04CD7.3080100@redhat.com>	<CAEgOgz6Jb2BKqRSV9ZPr0GMecw1ZJZSsjpRQ-2KSvQHmmx2dxw@mail.gmail.com>
	<53A0585E.5060701@redhat.com>
In-Reply-To: <53A0585E.5060701@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 5/5] mc146818rtc: add "rtc" link to
	"/machine"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Markus Armbruster <armbru@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

Am 17.06.2014 17:01, schrieb Paolo Bonzini:
> Il 17/06/2014 16:25, Peter Crosthwaite ha scritto:
>>> > &error_warn? :)  But then, /machine/rtc.tm is the only supported
>>> interface,
>> I have thought about &error_warn in the past, but thought the better
>> of it. Warnings need user digestable message and I can't think of a
>> sane implementation where you populate a message for error framework
>> to raise while maintaining the needed errp =3D=3D NULL || *errp =3D=3D=
 NULL
>> semantic at the same time.
>>
>>> > and it should be the same for all RTC devices so perhaps a NULL err=
or
>>> > pointer is enough.
>>> >
>> NULL Works for me. But other than source verbosity is there any reason
>> to not catch the error?:
>=20
> See above: it doesn't matter _which_ RTC gets the magic alias.  For a
> proper implementation, they should all be the same.

Doesn't this "alias" potentially change the canonical path since the new
property's type is going to be child<foo>?

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg