qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: emu-devel <qemu-devel@nongnu.org>,
	Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] add input-send-event command
Date: Tue, 17 Jun 2014 11:05:39 -0600	[thread overview]
Message-ID: <53A07563.5020606@redhat.com> (raw)
In-Reply-To: <20140617162209.GA6405@amt.cnet>

[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]

On 06/17/2014 10:22 AM, Marcelo Tosatti wrote:
> 
> Which allows specification of absolute/relative,
> up/down and console parameters.
> 
> Suggested by Gerd Hoffman.
> 
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> 
> ---
>  qapi-schema.json |   18 +++++++++++++++
>  qmp-commands.hx  |   63 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  ui/input.c       |   31 +++++++++++++++++++++++++++
>  3 files changed, 112 insertions(+)

> +
> +Example (1):
> +
> +Press left mouse button.

Maybe:

Press, then later release, left mouse button.

> +
> +-> { "execute": "input-send-event",
> +    "arguments": { "console": 0,
> +                   "events": [ { "type": "btn",
> +                    "data" : { "down": true, "button": "Left" } } } }
> +<- { "return": {} }
> +
> +-> { "execute": "input-send-event",
> +    "arguments": { "console": 0,
> +                   "events": [ { "type": "btn",
> +                    "data" : { "down": false, "button": "Left" } } } }
> +<- { "return": {} }

to make it clear that both command/response sequences are part of the
same example.

but that's cosmetic, so whether or not you change it, I can live with:

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2014-06-17 17:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-17 16:22 [Qemu-devel] [PATCH v2] add input-send-event command Marcelo Tosatti
2014-06-17 17:05 ` Eric Blake [this message]
2014-06-19 10:51 ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A07563.5020606@redhat.com \
    --to=eblake@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).