From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwwyy-0004ED-0B for qemu-devel@nongnu.org; Tue, 17 Jun 2014 13:15:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wwwyo-0001cz-OE for qemu-devel@nongnu.org; Tue, 17 Jun 2014 13:15:39 -0400 Received: from mail-qc0-x229.google.com ([2607:f8b0:400d:c01::229]:37955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwwyo-0001cN-Ky for qemu-devel@nongnu.org; Tue, 17 Jun 2014 13:15:30 -0400 Received: by mail-qc0-f169.google.com with SMTP id c9so10373804qcz.14 for ; Tue, 17 Jun 2014 10:15:30 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53A077AE.8010305@redhat.com> Date: Tue, 17 Jun 2014 19:15:26 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1402379781-844-1-git-send-email-pbonzini@redhat.com> <1402379781-844-3-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 2/8] vscclient: use glib thread primitives not qemu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ed Maste Cc: Michael Tokarev , qemu-devel Il 17/06/2014 19:10, Ed Maste ha scritto: > This change breaks the build on FreeBSD: > > libcacard/vscclient.c: In function 'send_msg': > libcacard/vscclient.c:111: warning: implicit declaration of function 'htonl' > libcacard/vscclient.c:111: warning: nested extern declaration of 'htonl' > libcacard/vscclient.c: In function 'on_host_init': > libcacard/vscclient.c:248: warning: implicit declaration of function 'ntohl' > libcacard/vscclient.c:248: warning: nested extern declaration of 'ntohl' > libcacard/vscclient.c: In function 'connect_to_qemu': > libcacard/vscclient.c:601: warning: implicit declaration of function 'socket' > libcacard/vscclient.c:601: warning: nested extern declaration of 'socket' Can you prepare a patch yourself? I would be guessing the right header to include, sorry. Paolo