From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55900)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WwxJs-0003oC-OB
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 13:37:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WwxJm-0003LI-LZ
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 13:37:16 -0400
Received: from mail-qc0-x236.google.com ([2607:f8b0:400d:c01::236]:46903)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WwxJm-0003Ky-8S
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 13:37:10 -0400
Received: by mail-qc0-f182.google.com with SMTP id m20so10482102qcx.13
	for <qemu-devel@nongnu.org>; Tue, 17 Jun 2014 10:37:09 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53A07CC2.3030401@redhat.com>
Date: Tue, 17 Jun 2014 19:37:06 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1402065233-31894-1-git-send-email-akong@redhat.com>
	<1402065233-31894-3-git-send-email-akong@redhat.com>
In-Reply-To: <1402065233-31894-3-git-send-email-akong@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 2/4] qtest: introduce qmp_exec_hmp_cmd()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amos Kong <akong@redhat.com>, qemu-devel@nongnu.org
Cc: stefanha@gmail.com, arei.gonglei@huawei.com, afaerber@suse.de

Il 06/06/2014 16:33, Amos Kong ha scritto:
> +    va_end(ap);
> +
> +    escaped_cmd = g_strescape(cmd, NULL);
> +    response = qmp("{\"execute\": \"human-monitor-command\","
> +                   " \"arguments\": {"
> +                   "   \"command-line\": \"%s\""
> +                   "}}", escaped_cmd);
> +    g_free(escaped_cmd);

Instead of adding g_strescape everywhere, we should use json-parser's 
own interpolation support.  See this patch: 
http://article.gmane.org/gmane.comp.emulators.qemu/279836 which also 
fixes a leak as a bonus.

Also, you can use ' instead of " if you fix another long-standing bug: 
http://article.gmane.org/gmane.comp.emulators.qemu/279835

Paolo