From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39390) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwy0M-0001v7-OX for qemu-devel@nongnu.org; Tue, 17 Jun 2014 14:21:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wwy0G-0002z1-PN for qemu-devel@nongnu.org; Tue, 17 Jun 2014 14:21:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwy0G-0002yx-I8 for qemu-devel@nongnu.org; Tue, 17 Jun 2014 14:21:04 -0400 Message-ID: <53A08709.9060001@redhat.com> Date: Tue, 17 Jun 2014 20:20:57 +0200 From: Max Reitz MIME-Version: 1.0 References: <1402912857-10509-1-git-send-email-benoit.canet@irqsave.net> <1402912857-10509-5-git-send-email-benoit.canet@irqsave.net> <53A06A2A.4070006@redhat.com> <20140617181914.GB25463@irqsave.net> In-Reply-To: <20140617181914.GB25463@irqsave.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v10 4/4] qemu-iotests: Add TestRepairQuorum to 041 to test drive-mirror node-name mode. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Beno=EEt_Canet?= Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On 17.06.2014 20:19, Beno=EEt Canet wrote: > The Tuesday 17 Jun 2014 =E0 18:17:46 (+0200), Max Reitz wrote : >> On 16.06.2014 12:00, Beno=EEt Canet wrote: >>> The to-replace-node-name is designed to allow repairing a broken Quor= um file. >>> This patch introduces a new class TestRepairQuorum testing that the f= eature >>> works. >>> Some further work will be done on QEMU to improve the robustness of t= he tests. >>> >>> Signed-off-by: Benoit Canet >>> --- >>> tests/qemu-iotests/041 | 196 ++++++++++++++++++++++++++++++++++= ++++++++++- >>> tests/qemu-iotests/041.out | 4 +- >>> 2 files changed, 194 insertions(+), 6 deletions(-) >> The test looks fine in general and it does work, so I would give it >> a reviewed-by. However, I still have some open questions from v9 >> about why this test works, so I'll still wait. ;-) > It works because node name is a linked list so the insertion order make= the > positions in the json predictible. Oh, sorry, I just saw your reply to my review for v9. Thank you. :-) Max