From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44119)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WwyL1-0001du-UK
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 14:42:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WwyKw-0002B7-Ra
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 14:42:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34631)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WwyKw-0002At-Gz
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 14:42:26 -0400
Message-ID: <53A08C07.1050704@redhat.com>
Date: Tue, 17 Jun 2014 12:42:15 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1403021756-15960-1-git-send-email-mst@redhat.com>
	<1403021756-15960-14-git-send-email-mst@redhat.com>
In-Reply-To: <1403021756-15960-14-git-send-email-mst@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="DHV8x49dB4se6p0tPxK58hsECAwENDtTw"
Subject: Re: [Qemu-devel] [PULL 013/103] pc: exit QEMU if number of slots
 more than supported 256
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Stefan Hajnoczi <stefanha@redhat.com>, Alex Bligh <alex@alex.org.uk>, Anthony Liguori <aliguori@amazon.com>, Peter Crosthwaite <peter.crostwaite@xilinx.com>, Igor Mammedov <imammedo@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--DHV8x49dB4se6p0tPxK58hsECAwENDtTw
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 06/17/2014 11:37 AM, Michael S. Tsirkin wrote:
> From: Igor Mammedov <imammedo@redhat.com>
>=20
> ... which is imposed by current naming scheme of ACPI memory devices.
>=20
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Acked-by: Peter Crosthwaite <peter.crostwaite@xilinx.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---

> +/*
> + * current device naming scheme supports
> + * only upto 256 memory devices

s/upto/up to/ (while English has several compound words such as "into"
or "onto", it does not have an "upto").

Probably too late for this pull request, but something you could clean
up as a followup

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--DHV8x49dB4se6p0tPxK58hsECAwENDtTw
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJToIwHAAoJEKeha0olJ0NqLlYH/R3azDyDtpndSAkFucpIlElP
3bhFSJkRa7471foR0WHYQTHv3dCIU3gKzTXvA9Vkg8MjuOvvckPx6mvK5ejFov6T
+C/s4YKC1GuZ6iCViUAGzaAqQRd3BH/48mzUrY4aZbPZAN/NdAmsm3kaBNkw7lwT
bUC1fbYgB2yMXhXimLKUXJ2dnZLYrTJnsWZR1SwTnJVPgrWzLDF5K0aUJiCEAkzu
mL46dvYyE7ht0rudUBuBjYQ5GlUkWtbh6dpWqDBgUkvKmgdHFCDWGTUu9jEJwWwW
+l/agJjOaKg0ST0aLNlu0dMWwhDKCG4BnE88Wq1THcUJLfr16XKO11GD1kgClY4=
=V9St
-----END PGP SIGNATURE-----

--DHV8x49dB4se6p0tPxK58hsECAwENDtTw--