From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwyVv-0000cY-CK for qemu-devel@nongnu.org; Tue, 17 Jun 2014 14:53:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwyVp-0007Fm-Il for qemu-devel@nongnu.org; Tue, 17 Jun 2014 14:53:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwyVp-0007EG-9X for qemu-devel@nongnu.org; Tue, 17 Jun 2014 14:53:41 -0400 Message-ID: <53A08EB0.2010304@redhat.com> Date: Tue, 17 Jun 2014 12:53:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403021756-15960-1-git-send-email-mst@redhat.com> <1403021756-15960-12-git-send-email-mst@redhat.com> <53A08B64.4050605@redhat.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oDR1P4u3xA2vwNoAuG6nGQ4ML4O0eLelE" Subject: Re: [Qemu-devel] [PULL 011/103] pc-dimm: do not allow to set already used memdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "Michael S. Tsirkin" , QEMU Developers , Vasilis Liaskovitis , Anthony Liguori , Peter Crosthwaite , Igor Mammedov This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oDR1P4u3xA2vwNoAuG6nGQ4ML4O0eLelE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/17/2014 12:45 PM, Peter Maydell wrote: > On 17 June 2014 19:39, Eric Blake wrote: >> On 06/17/2014 11:36 AM, Michael S. Tsirkin wrote: >>> From: Igor Mammedov >>> >>> using the same memdev backend more than once will cause >>> assersion at MemoryRegion mapping time becase it's already >> >> s/assersion/assertion/; s/becase/because/ >> (but probably too late now that this is a pull request) >=20 > Incidentally, if anybody notices something that should > mean a pull request ought not to be applied, they need > to send an email which is a followup to the cover letter. > Otherwise there's no guarantee I'll notice it when I'm > processing the pullreq. Got it. So far, all that I've pointed out can be done as followups (typos in code) or ignored as too late (typos in commit message) - I haven't found anything that should prevent this pull request from actually going in. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --oDR1P4u3xA2vwNoAuG6nGQ4ML4O0eLelE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJToI6wAAoJEKeha0olJ0NqIlMH/1CNFntxwkT6PQqj/IubW7A+ K8QZbzCC9e69CA4z29+F4fw1ZtKvgunpuPg7WGAJ97zaw8r36ssEFVzOZyOLTbsO cPBNDaUfqNXhpYueP5JWXhlTVFH1gtJkxlPx+E4LHxIW1wZmgtyb44iY626zb2hY f/G68fOVkn/muZMc8TKIfuZPvN5ZpbTiSXl4w0HCRdLxWBCzGWl06fyCw6JSaOjn d+78ow3AR2QfFrM5Lp/EW1IcRsCr3zocHsQGQGJGDv8gUwoiNxXLHhQchsHp76EQ mWOtWSk3dNx5VtTHsCyHpKBowNHTjJaf50k0mamlpsU5WB7S4Yplgq6A8J1rc8Q= =E+Cy -----END PGP SIGNATURE----- --oDR1P4u3xA2vwNoAuG6nGQ4ML4O0eLelE--