From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wx05J-0000Bl-Fo for qemu-devel@nongnu.org; Tue, 17 Jun 2014 16:34:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wx05D-0008HY-7V for qemu-devel@nongnu.org; Tue, 17 Jun 2014 16:34:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39870 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wx05C-0008HR-Te for qemu-devel@nongnu.org; Tue, 17 Jun 2014 16:34:19 -0400 Message-ID: <53A0A648.800@suse.de> Date: Tue, 17 Jun 2014 22:34:16 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1403035900-31820-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1403035900-31820-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] taget-i386: Broadwell CPU model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Paolo Bonzini , "Wang, Yong Y" , "Dugger, Donald D" "target" Am 17.06.2014 22:11, schrieb Eduardo Habkost: > This adds a new CPU model named "Broadwell". It has all the features > from Haswell, plus PREFETCHW, RDSEED, ADX, SMAP. >=20 > PREFETCHW was already supported as "3dnowprefetch". >=20 > RDSEED, ADX was added on Linux v3.15-rc1. >=20 > SMAP was added on Linux v3.15-rc2. >=20 > Signed-off-by: Eduardo Habkost > Cc: Wang, Yong Y > Cc: Paolo Bonzini > Cc: Dugger, Donald D > --- > target-i386/cpu.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) >=20 > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 8983457..027a9b5 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -971,6 +971,40 @@ static X86CPUDefinition builtin_x86_defs[] =3D { > .model_id =3D "Intel Core Processor (Haswell)", > }, > { > + .name =3D "Broadwell", > + .level =3D 0xd, > + .vendor =3D CPUID_VENDOR_INTEL, > + .family =3D 6, > + .model =3D 61, > + .stepping =3D 2, > + .features[FEAT_1_EDX] =3D > + CPUID_SSE2 | CPUID_SSE | CPUID_FXSR | CPUID_MMX | > + CPUID_CLFLUSH | CPUID_PSE36 | CPUID_PAT | CPUID_CMOV | CP= UID_MCA | > + CPUID_PGE | CPUID_MTRR | CPUID_SEP | CPUID_APIC | CPUID_C= X8 | > + CPUID_MCE | CPUID_PAE | CPUID_MSR | CPUID_TSC | CPUID_PSE= | > + CPUID_DE | CPUID_FP87, The indentation looks inconsistent (1 off), although I don't see a tab character in the mix... > + .features[FEAT_1_ECX] =3D > + CPUID_EXT_AVX | CPUID_EXT_XSAVE | CPUID_EXT_AES | > + CPUID_EXT_POPCNT | CPUID_EXT_X2APIC | CPUID_EXT_SSE42 | > + CPUID_EXT_SSE41 | CPUID_EXT_CX16 | CPUID_EXT_SSSE3 | > + CPUID_EXT_PCLMULQDQ | CPUID_EXT_SSE3 | > + CPUID_EXT_TSC_DEADLINE_TIMER | CPUID_EXT_FMA | CPUID_EXT_= MOVBE | > + CPUID_EXT_PCID, > + .features[FEAT_8000_0001_EDX] =3D > + CPUID_EXT2_LM | CPUID_EXT2_RDTSCP | CPUID_EXT2_NX | > + CPUID_EXT2_SYSCALL, > + .features[FEAT_8000_0001_ECX] =3D > + CPUID_EXT3_LAHF_LM | CPUID_EXT3_3DNOWPREFETCH, > + .features[FEAT_7_0_EBX] =3D > + CPUID_7_0_EBX_FSGSBASE | CPUID_7_0_EBX_BMI1 | > + CPUID_7_0_EBX_HLE | CPUID_7_0_EBX_AVX2 | CPUID_7_0_EBX_SME= P | > + CPUID_7_0_EBX_BMI2 | CPUID_7_0_EBX_ERMS | CPUID_7_0_EBX_IN= VPCID | > + CPUID_7_0_EBX_RTM | CPUID_7_0_EBX_RDSEED | CPUID_7_0_EBX_A= DX | > + CPUID_7_0_EBX_SMAP, > + .xlevel =3D 0x8000000A, > + .model_id =3D "Intel Core Processor (Broadwell)", > + }, > + { > .name =3D "Opteron_G1", > .level =3D 5, > .vendor =3D CPUID_VENDOR_AMD, Apart from that, looks sane, so if someone can confirm the Broadwell-specific values I'll be happy to fix the style and queue it for 2.1. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg