From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33134)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wenchaoqemu@gmail.com>) id 1Wx1b0-0006QM-SL
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 18:11:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wenchaoqemu@gmail.com>) id 1Wx1aq-0007RB-7g
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 18:11:14 -0400
Received: from mail-pb0-x236.google.com ([2607:f8b0:400e:c01::236]:41515)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wenchaoqemu@gmail.com>) id 1Wx1aq-0007Qq-0o
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 18:11:04 -0400
Received: by mail-pb0-f54.google.com with SMTP id un15so3086638pbc.13
	for <qemu-devel@nongnu.org>; Tue, 17 Jun 2014 15:11:03 -0700 (PDT)
Message-ID: <53A0BCD7.1060003@gmail.com>
Date: Wed, 18 Jun 2014 06:10:31 +0800
From: Wenchao Xia <wenchaoqemu@gmail.com>
MIME-Version: 1.0
References: <1401970944-18735-1-git-send-email-wenchaoqemu@gmail.com>	<53969C25.7010705@redhat.com>	<539CEE42.5090906@gmail.com>
	<53A01F06.5000209@redhat.com> <53A06752.4060206@redhat.com>
	<53A06D2D.8010000@redhat.com>
In-Reply-To: <53A06D2D.8010000@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH V6 00/29] add direct support of event in
 qapi schema
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: lcapitulino@redhat.com, armbru@redhat.com, mdroth@linux.vnet.ibm.com

于 2014/6/18 0:30, Paolo Bonzini 写道:
> Il 17/06/2014 18:05, Eric Blake ha scritto:
>>> diff --git a/Makefile b/Makefile
>>> index 3e65525..f473cf5 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -246,8 +246,7 @@ $(SRC_PATH)/qga/qapi-schema.json
>>> $(SRC_PATH)/scripts/qapi-commands.py $(qapi-py)
>>>          $(gen-out-type) -o "." -b -i $<, \
>>>          "  GEN   $@")
>>>  qapi-event.c qapi-event.h :\
>>> -$(SRC_PATH)/qapi-schema.json $(SRC_PATH)/qapi-event.json \
>>> -$(SRC_PATH)/scripts/qapi-event.py $(qapi-py)
>>> +$(qapi-modules) $(SRC_PATH)/scripts/qapi-event.py $(qapi-py)
>>
>> Where's the change that adds qapi/event.json to $(qapi-modules)?  (Maybe
>> the interdiff doesn't show it?)
>
> Oops, it's not there.
>
>>> +++ b/include/sysemu/os-posix.h
>>> @@ -26,8 +26,6 @@
>>>  #ifndef QEMU_OS_POSIX_H
>>>  #define QEMU_OS_POSIX_H
>>>
>>> -#include <sys/time.h>
>>> -
>>>  void os_set_line_buffering(void);
>>
>> Why this hunk? Did you accidentally forget to include Wenchao's 1/29 in
>> your series?
>
> Yes, fixing now.
>
>>> @@ -535,14 +533,15 @@ static void monitor_qapi_event_handler(void
>>> *opaque)
>>>   * more than 1 event will be emitted within @rate
>>>   * milliseconds
>>>   */
>>> -static void monitor_qapi_event_throttle(QAPIEvent event, int64_t rate)
>>> +static void
>>> +monitor_qapi_event_throttle(QAPIEvent event, int64_t rate)
>>>  {
>>
>> Not the usual qemu formatting style.
>
> Yeah, this happened because of __attribute__((__unused__)) and matches
> other monitor_qapi_ functions.  I kind of like the
> return-type-then-newline too. :)
>
>> Overall the interdiff looks like it resolves most of my concerns on v6.
>>  Now for me to read the actual commits in your git repo...
>
> Will fix in a moment.
>
> Paolo
   If you and Eric think v6 is OK to catch up 2.1, I can send a clean up
patch fixing the typo/doc issues after merge.