From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wx1ox-0004SW-Dh for qemu-devel@nongnu.org; Tue, 17 Jun 2014 18:25:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wx1oq-000407-3i for qemu-devel@nongnu.org; Tue, 17 Jun 2014 18:25:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wx1op-0003zd-QI for qemu-devel@nongnu.org; Tue, 17 Jun 2014 18:25:32 -0400 Message-ID: <53A0C057.6000205@redhat.com> Date: Tue, 17 Jun 2014 16:25:27 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WCXQQsxf5sSmFs3upnWIbJ2hNIx7BWwSG" Subject: Re: [Qemu-devel] [PATCH v6 for 2.1 04/10] block: make 'top' argument to block-commit optional List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, benoit.canet@irqsave.net, pkrempa@redhat.com, famz@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WCXQQsxf5sSmFs3upnWIbJ2hNIx7BWwSG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/17/2014 03:53 PM, Jeff Cody wrote: > Now that active layer block-commit is supported, the 'top' argument > no longer needs to be mandatory. >=20 > Change it to optional, with the default being the active layer in the > device chain. >=20 > Reviewed-by: Eric Blake > Reviewed-by: Benoit Canet > Signed-off-by: Jeff Cody > --- As mentioned elsewhere, this is the patch that changed from v5. But so there's no confusion, I've gone back over this one, and my R-b still stan= ds. > + /* Important Note: > + * libvirt relies on the DeviceNotFound error class in order to p= robe for > + * live commit feature versions; for this to work, we must make s= ure to > + * perform the device lookup before any generic errors that may o= ccur in a > + * scenario in which all optional arguments are omitted. */ > bs =3D bdrv_find(device); > if (!bs) { > error_set(errp, QERR_DEVICE_NOT_FOUND, device); Thanks for adding the comment :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --WCXQQsxf5sSmFs3upnWIbJ2hNIx7BWwSG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJToMBYAAoJEKeha0olJ0NqQTcIAKvT5GmxCA7Asrk+qKqiuI5/ wrEF3SpcxdAIqQqdOzHaz5uuPGLV2PQ7dJuWYyTHIlQLAw0hJmxTHp9VSTYrLeCu lBa/XAoMOi9QcPtRhkaEr7quEN1J8eVb0WoVZYf8C3g+m0Xl2hcrm2cJqYcFVFta uhuBKDu9NC8ZVZ3CDhMnI3mqfugAUlXOhXOsWYvc3cgs8jYOG500TjuhbCiWejfR 1/pd/J0weYt65O+CMtCpFE9oPHtlilDAr0Q5CGQOI2yYhv8/+8+2e05mrA93GIPY xUp4baZTDumC22WqaDJQNJ8qln+V2pWDZYiz1378J1rt7kGwpQOh2jDLk5rI21A= =UY8m -----END PGP SIGNATURE----- --WCXQQsxf5sSmFs3upnWIbJ2hNIx7BWwSG--