From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wx73P-0005Jd-2e for qemu-devel@nongnu.org; Wed, 18 Jun 2014 00:00:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wx73K-0000yj-08 for qemu-devel@nongnu.org; Wed, 18 Jun 2014 00:00:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wx73J-0000yf-N7 for qemu-devel@nongnu.org; Wed, 18 Jun 2014 00:00:49 -0400 Message-ID: <53A10EEC.8070109@redhat.com> Date: Tue, 17 Jun 2014 22:00:44 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401970944-18735-1-git-send-email-wenchaoqemu@gmail.com> <53969C25.7010705@redhat.com> <539CEE42.5090906@gmail.com> <53A01F06.5000209@redhat.com> In-Reply-To: <53A01F06.5000209@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ehh8c7tXcVHm6t8jFGw5hI7IfnBFdPo5c" Subject: Re: [Qemu-devel] [PATCH V6 00/29] add direct support of event in qapi schema List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Wenchao Xia , qemu-devel@nongnu.org Cc: lcapitulino@redhat.com, armbru@redhat.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ehh8c7tXcVHm6t8jFGw5hI7IfnBFdPo5c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/17/2014 04:57 AM, Paolo Bonzini wrote: > Il 15/06/2014 02:52, Wenchao Xia ha scritto: >>> Unfortunately, this already does not apply anymore. >>> >>> I've placed the rebase on branch qapi-event of my github repository. = The >>> resolutions are trivial, so perhaps Luiz or Michael can pull from the= re? >>> >>> Paolo >> I'm still reviewing your git tree; I raised a couple comments on 3/29 (see my replies there). Also: > +++ b/include/qapi/qmp-event.h > @@ -17,7 +17,7 @@ > #include "qapi/error.h" > #include "qapi/qmp/qdict.h" > =20 > -typedef void (*QMPEventFuncEmit)(int event_kind, QDict *dict, Error **= errp); > +typedef void (*QMPEventFuncEmit)(unsigned event, QDict *dict, Error **= errp); It looks like you have some churn on this definition; patch 4/29 in your qapi-event branch did: -enum QAPIEvent; -typedef void (*QMPEventFuncEmit)(enum QAPIEvent event, QDict *dict, Error **errp); +typedef void (*QMPEventFuncEmit)(unsigned event, QDict *dict, Error **errp); Can you hoist the use of 'unsigned' directly into 2/29 to minimize the churn? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ehh8c7tXcVHm6t8jFGw5hI7IfnBFdPo5c Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJToQ7sAAoJEKeha0olJ0Nqq9UIAIvQxC44PILMUUoOI2JOkBCT v41lEZB0FyK5ODnE9Thvcgm1ZcR5NhX1kfRn4FUSRzGWcHgw2m8YPvpeuktJTUKY uy10FH7dG1oYVTVUdLLHviIKQ7WaaDXjnJGO8h/MKxGb2wywmdcQJgHC8vcsXpKX IDBgNRlRMzVXp0+OhLHX0GfzP3tz6Kj0IFbAJEI9PvoBGaS1HSg5IHSsJFiaJJPW DOnWtfazj06LUkvM7jDQ19YOMrvSlwVdj8WgQTDwYKe28u0HrZjQjSR9NVDWfJYx 1Evl/BKL6CeK+Ugj45ctr5a6JtAOVoKPu+1UdS4RBDYoDvrq6ik7zzmtswgmM8E= =VPV9 -----END PGP SIGNATURE----- --ehh8c7tXcVHm6t8jFGw5hI7IfnBFdPo5c--