From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wx76T-0006RS-Ul for qemu-devel@nongnu.org; Wed, 18 Jun 2014 00:04:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wx76P-00025y-Rj for qemu-devel@nongnu.org; Wed, 18 Jun 2014 00:04:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wx76P-00025u-JI for qemu-devel@nongnu.org; Wed, 18 Jun 2014 00:04:01 -0400 Message-ID: <53A10FB0.3050903@redhat.com> Date: Tue, 17 Jun 2014 22:04:00 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403059646-4161-1-git-send-email-cyliu@suse.com> In-Reply-To: <1403059646-4161-1-git-send-email-cyliu@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s1O4okBFIj2BGP58movjeqaBBclHum3sh" Subject: Re: [Qemu-devel] [PATCH] check NULL opts in qemu_opt_get functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu , stefanha@redhat.com Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --s1O4okBFIj2BGP58movjeqaBBclHum3sh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/17/2014 08:47 PM, Chunyan Liu wrote: > Some places will call bdrv_create_file(filename, NULL, &local_err), whe= re > opts is NULL. Check NULL in qemu_opt_get and qemu_opt_get_*_del functio= ns, > to avoid extra effort of checking opts before calling them every time. >=20 > Signed-off-by: Chunyan Liu > --- > Fix reported bugs: > http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg03866.html >=20 > --- > util/qemu-option.c | 28 ++++++++++++++++++++++++---- > 1 file changed, 24 insertions(+), 4 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --s1O4okBFIj2BGP58movjeqaBBclHum3sh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJToQ+wAAoJEKeha0olJ0NqRlUH/2tA0ffJsEx3jEAv7glDQd14 D4ad0jYCRBpHnNYXa/m+xk8Jrf7KmOwrQ1SicnxrDxLJ0g8Nh5614o2kBQNeJZRd e6dkF07NmCbWNXDRRbIzWbnYufgc/cJy34lMEo/KbLE6cPicq1w7rH64r/4T/P19 9dTnChvyBEN8AkxcYImF/psgQVidcjicv07j62PazJ+ffikFVK6/AkPG9JLJT6wH hse8+bXSHSxs/IvajjbpfH0+J4qD4fiEpEF5VSHCQKTK2PXEojY8U9YZEpj3oWmw 6EUDkCCfEE5lTUcOjnKMkmWdBEY1dorqiHJyvExJm/4K0glnlVwnfkPlJi4Nyvo= =V6LW -----END PGP SIGNATURE----- --s1O4okBFIj2BGP58movjeqaBBclHum3sh--