From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47528)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wx91p-0002LD-Ku
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 02:07:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wx91g-0007WE-8n
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 02:07:25 -0400
Received: from mail-qc0-x232.google.com ([2607:f8b0:400d:c01::232]:64378)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wx91g-0007W7-5A
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 02:07:16 -0400
Received: by mail-qc0-f178.google.com with SMTP id c9so325747qcz.23
	for <qemu-devel@nongnu.org>; Tue, 17 Jun 2014 23:07:15 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53A12C8F.5000600@redhat.com>
Date: Wed, 18 Jun 2014 08:07:11 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1401970944-18735-1-git-send-email-wenchaoqemu@gmail.com>	<53969C25.7010705@redhat.com>	<539CEE42.5090906@gmail.com>	<53A01F06.5000209@redhat.com>
	<53A10EEC.8070109@redhat.com>
In-Reply-To: <53A10EEC.8070109@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V6 00/29] add direct support of event in
	qapi schema
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, Wenchao Xia <wenchaoqemu@gmail.com>, qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com, armbru@redhat.com, lcapitulino@redhat.com

Il 18/06/2014 06:00, Eric Blake ha scritto:
>> > -typedef void (*QMPEventFuncEmit)(int event_kind, QDict *dict, Error **errp);
>> > +typedef void (*QMPEventFuncEmit)(unsigned event, QDict *dict, Error **errp);
> It looks like you have some churn on this definition; patch 4/29 in your
> qapi-event branch did:
>
> -enum QAPIEvent;
> -typedef void (*QMPEventFuncEmit)(enum QAPIEvent event, QDict *dict,
> Error **errp);
> +typedef void (*QMPEventFuncEmit)(unsigned event, QDict *dict, Error
> **errp);
>
> Can you hoist the use of 'unsigned' directly into 2/29 to minimize the
> churn?

Yes, will fix in a couple of hours.

Paolo