From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58943)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wx9vp-0003f6-DP
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 03:05:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wx9vj-0001Tf-BZ
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 03:05:17 -0400
Received: from mail-qc0-x234.google.com ([2607:f8b0:400d:c01::234]:35790)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wx9vj-0001TZ-8T
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 03:05:11 -0400
Received: by mail-qc0-f180.google.com with SMTP id r5so368048qcx.25
	for <qemu-devel@nongnu.org>; Wed, 18 Jun 2014 00:05:10 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53A13A22.5080102@redhat.com>
Date: Wed, 18 Jun 2014 09:05:06 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1402065233-31894-1-git-send-email-akong@redhat.com>	<1402065233-31894-3-git-send-email-akong@redhat.com>	<53A07CC2.3030401@redhat.com>
	<20140618062911.GC32372@z.redhat.com>
In-Reply-To: <20140618062911.GC32372@z.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 2/4] qtest: introduce qmp_exec_hmp_cmd()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amos Kong <akong@redhat.com>
Cc: stefanha@gmail.com, arei.gonglei@huawei.com, qemu-devel@nongnu.org, afaerber@suse.de

Il 18/06/2014 08:29, Amos Kong ha scritto:
>> > Instead of adding g_strescape everywhere, we should use json-parser's own
>> > interpolation support.  See this patch:
>> > http://article.gmane.org/gmane.comp.emulators.qemu/279836 which also fixes a
>> > leak as a bonus.
>> >
>> > Also, you can use ' instead of " if you fix another long-standing bug:
>> > http://article.gmane.org/gmane.comp.emulators.qemu/279835
> I will use ' instead of ", and escape string in QMP command as http://article.gmane.org/gmane.comp.emulators.qemu/279836

Thanks Amos!  This will avoid duplicating work as well as semantic 
conflicts.  I've added your Reviewed-by for the lexer patch.

Paolo