From: Paolo Bonzini <pbonzini@redhat.com>
To: Ed Maste <emaste@freebsd.org>
Cc: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 2/8] vscclient: use glib thread primitives not qemu
Date: Wed, 18 Jun 2014 11:25:56 +0200 [thread overview]
Message-ID: <53A15B24.60908@redhat.com> (raw)
In-Reply-To: <CAPyFy2AyR=rCgLZ=G2MFf=+NdLBbJLkXXc87TgvH3vYEQZtoQQ@mail.gmail.com>
Il 17/06/2014 21:11, Ed Maste ha scritto:
> On 17 June 2014 13:15, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 17/06/2014 19:10, Ed Maste ha scritto:
>>
>>> This change breaks the build on FreeBSD:
>>>
>>> libcacard/vscclient.c: In function 'send_msg':
>>> libcacard/vscclient.c:111: warning: implicit declaration of function
>>> 'htonl'
>>> ...
>>
>> Can you prepare a patch yourself? I would be guessing the right header to
>> include, sorry.
>
> I can get it to build by either restoring the #include of
> qemu/sockets.h, or explicitly #including sys/socket.h and
> netinet/in.h.
The latter is better, this patch meant to remove most (though not yet
all) dependencies of libcacard on include/qemu/.
I'm happy to send a signed-off patch for either change,
> but it seems there must be more to the original change that I'm
> missing. What provides the declarations for socket(), htonl(),
> AF_INET etc. in the Linux build?
netdb.h includes netinet/in.h, and netinet/in.h includes sys/socket.h.
glibc is not particularly good at avoiding #includes within headers. :(
Paolo
next prev parent reply other threads:[~2014-06-18 9:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 5:56 [Qemu-devel] [PULL 0/8] build system and libcacard changes for 2014-06-10 Paolo Bonzini
2014-06-10 5:56 ` [Qemu-devel] [PULL 1/8] glib-compat.h: add new thread API emulation on top of pre-2.31 API Paolo Bonzini
2014-06-10 5:56 ` [Qemu-devel] [PULL 2/8] vscclient: use glib thread primitives not qemu Paolo Bonzini
2014-06-17 17:10 ` Ed Maste
2014-06-17 17:15 ` Paolo Bonzini
2014-06-17 19:11 ` Ed Maste
2014-06-18 9:25 ` Paolo Bonzini [this message]
2014-06-10 5:56 ` [Qemu-devel] [PULL 3/8] libcacard: replace qemu thread primitives with glib ones Paolo Bonzini
2014-06-10 5:56 ` [Qemu-devel] [PULL 4/8] libcacard: actually use symbols file Paolo Bonzini
2014-06-10 5:56 ` [Qemu-devel] [PULL 5/8] libcacard: improve documentation Paolo Bonzini
2014-06-10 5:56 ` [Qemu-devel] [PULL 6/8] rules.mak: Rewrite unnest-vars Paolo Bonzini
2014-06-10 10:40 ` Paolo Bonzini
2014-06-10 5:56 ` [Qemu-devel] [PULL 7/8] configure: duplicate/incorrect order of -lrt Paolo Bonzini
2014-06-10 5:56 ` [Qemu-devel] [PULL 8/8] configure: unset interfering variables Paolo Bonzini
2014-06-10 10:00 ` [Qemu-devel] [PULL 0/8] build system and libcacard changes for 2014-06-10 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A15B24.60908@redhat.com \
--to=pbonzini@redhat.com \
--cc=emaste@freebsd.org \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).