From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58417)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WxC8M-0000cS-4V
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 05:26:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WxC8G-0007v1-0B
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 05:26:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63239)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WxC8F-0007uv-Ob
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 05:26:15 -0400
Message-ID: <53A15B24.60908@redhat.com>
Date: Wed, 18 Jun 2014 11:25:56 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1402379781-844-1-git-send-email-pbonzini@redhat.com>	<1402379781-844-3-git-send-email-pbonzini@redhat.com>	<CAPyFy2CguMUVm3A5=sLueR9sG6yEDd3-=iyek5h7RacNYzMC0w@mail.gmail.com>	<53A077AE.8010305@redhat.com>
	<CAPyFy2AyR=rCgLZ=G2MFf=+NdLBbJLkXXc87TgvH3vYEQZtoQQ@mail.gmail.com>
In-Reply-To: <CAPyFy2AyR=rCgLZ=G2MFf=+NdLBbJLkXXc87TgvH3vYEQZtoQQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 2/8] vscclient: use glib thread primitives
	not qemu
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ed Maste <emaste@freebsd.org>
Cc: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel <qemu-devel@nongnu.org>

Il 17/06/2014 21:11, Ed Maste ha scritto:
> On 17 June 2014 13:15, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 17/06/2014 19:10, Ed Maste ha scritto:
>>
>>> This change breaks the build on FreeBSD:
>>>
>>> libcacard/vscclient.c: In function 'send_msg':
>>> libcacard/vscclient.c:111: warning: implicit declaration of function
>>> 'htonl'
>>> ...
>>
>> Can you prepare a patch yourself?  I would be guessing the right header to
>> include, sorry.
>
> I can get it to build by either restoring the #include of
> qemu/sockets.h, or explicitly #including sys/socket.h and
> netinet/in.h.

The latter is better, this patch meant to remove most (though not yet 
all) dependencies of libcacard on include/qemu/.

   I'm happy to send a signed-off patch for either change,
> but it seems there must be more to the original change that I'm
> missing.  What provides the declarations for socket(), htonl(),
> AF_INET etc. in the Linux build?

netdb.h includes netinet/in.h, and netinet/in.h includes sys/socket.h. 
glibc is not particularly good at avoiding #includes within headers. :(

Paolo