From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Andreas Faerber <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/3] virtio-blk: replace x-iothread with iothread link property
Date: Wed, 18 Jun 2014 15:01:10 +0200 [thread overview]
Message-ID: <53A18D96.5020104@redhat.com> (raw)
In-Reply-To: <CAJSP0QXheCwKJDz7oqmjgwRams777UOvS9v=HrV4O04knm7kZg@mail.gmail.com>
Il 18/06/2014 13:11, Stefan Hajnoczi ha scritto:
>> >
>> > Actually this won't work. Link properties have to have a LinkProperty
>> > opaque.
>> >
>> > The series I posted to add a "resolve" callback for properties can be used
>> > here, fixing object_property_add_alias to add a "resolve" callback to the
>> > newly-created property.
>> >
>> > My ack for this patch still stands, it's just a matter of patch ordering.
> Okay, then it makes sense to hold this back until your patch is merged.
As discussed on IRC though, if the basic use case works, go ahead. If
there are bugs on fringe cases (such as iothread=vbp1/iothread where
vbp1 is a virtio-blk-pci device), we can fix them in hard freeze.
Paolo
next prev parent reply other threads:[~2014-06-18 13:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 7:03 [Qemu-devel] [PATCH 0/3] dataplane: introduce virtio-blk.iothread property Stefan Hajnoczi
2014-06-10 7:03 ` [Qemu-devel] [PATCH 1/3] virtio-blk: replace x-iothread with iothread link property Stefan Hajnoczi
2014-06-10 18:35 ` Paolo Bonzini
2014-06-18 11:11 ` Stefan Hajnoczi
2014-06-18 13:01 ` Paolo Bonzini [this message]
2014-06-10 7:03 ` [Qemu-devel] [PATCH 2/3] qdev: drop iothread property type Stefan Hajnoczi
2014-06-10 7:03 ` [Qemu-devel] [PATCH 3/3] virtio-blk: remove need for explicit x-data-plane=on option Stefan Hajnoczi
2014-06-10 9:03 ` [Qemu-devel] [PATCH 0/3] dataplane: introduce virtio-blk.iothread property Paolo Bonzini
2014-06-30 13:09 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A18D96.5020104@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).