From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxFUS-0004CR-BV for qemu-devel@nongnu.org; Wed, 18 Jun 2014 09:01:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxFUK-00061s-Rj for qemu-devel@nongnu.org; Wed, 18 Jun 2014 09:01:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxFUK-00061k-Jf for qemu-devel@nongnu.org; Wed, 18 Jun 2014 09:01:16 -0400 Message-ID: <53A18D96.5020104@redhat.com> Date: Wed, 18 Jun 2014 15:01:10 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1402383802-14252-1-git-send-email-stefanha@redhat.com> <1402383802-14252-2-git-send-email-stefanha@redhat.com> <53974FF7.5010504@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] virtio-blk: replace x-iothread with iothread link property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel , Stefan Hajnoczi , Andreas Faerber Il 18/06/2014 13:11, Stefan Hajnoczi ha scritto: >> > >> > Actually this won't work. Link properties have to have a LinkProperty >> > opaque. >> > >> > The series I posted to add a "resolve" callback for properties can be used >> > here, fixing object_property_add_alias to add a "resolve" callback to the >> > newly-created property. >> > >> > My ack for this patch still stands, it's just a matter of patch ordering. > Okay, then it makes sense to hold this back until your patch is merged. As discussed on IRC though, if the basic use case works, go ahead. If there are bugs on fringe cases (such as iothread=vbp1/iothread where vbp1 is a virtio-blk-pci device), we can fix them in hard freeze. Paolo