* [Qemu-devel] [PATCH] vscclient: Add required headers to fix build on FreeBSD
@ 2014-06-18 12:58 Ed Maste
2014-06-18 14:41 ` Paolo Bonzini
2014-06-21 12:48 ` Michael Tokarev
0 siblings, 2 replies; 5+ messages in thread
From: Ed Maste @ 2014-06-18 12:58 UTC (permalink / raw)
To: qemu-devel; +Cc: Ed Maste
Signed-off-by: Ed Maste <emaste@freebsd.org>
---
libcacard/vscclient.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
index ab9b2b8..80111df 100644
--- a/libcacard/vscclient.c
+++ b/libcacard/vscclient.c
@@ -11,6 +11,8 @@
*/
#ifndef _WIN32
+#include <sys/socket.h>
+#include <netinet/in.h>
#include <netdb.h>
#define closesocket(x) close(x)
#endif
--
1.8.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vscclient: Add required headers to fix build on FreeBSD
2014-06-18 12:58 [Qemu-devel] [PATCH] vscclient: Add required headers to fix build on FreeBSD Ed Maste
@ 2014-06-18 14:41 ` Paolo Bonzini
2014-06-18 15:22 ` Andreas Färber
2014-06-21 12:48 ` Michael Tokarev
1 sibling, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2014-06-18 14:41 UTC (permalink / raw)
To: Ed Maste, qemu-devel
Il 18/06/2014 14:58, Ed Maste ha scritto:
> Signed-off-by: Ed Maste <emaste@freebsd.org>
> ---
> libcacard/vscclient.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
> index ab9b2b8..80111df 100644
> --- a/libcacard/vscclient.c
> +++ b/libcacard/vscclient.c
> @@ -11,6 +11,8 @@
> */
>
> #ifndef _WIN32
> +#include <sys/socket.h>
> +#include <netinet/in.h>
> #include <netdb.h>
> #define closesocket(x) close(x)
> #endif
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vscclient: Add required headers to fix build on FreeBSD
2014-06-18 14:41 ` Paolo Bonzini
@ 2014-06-18 15:22 ` Andreas Färber
2014-06-20 20:38 ` Ed Maste
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Färber @ 2014-06-18 15:22 UTC (permalink / raw)
To: Paolo Bonzini, Ed Maste, qemu-devel; +Cc: qemu-trivial, Alon Levy
Am 18.06.2014 16:41, schrieb Paolo Bonzini:
> Il 18/06/2014 14:58, Ed Maste ha scritto:
>> Signed-off-by: Ed Maste <emaste@freebsd.org>
>> ---
>> libcacard/vscclient.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
>> index ab9b2b8..80111df 100644
>> --- a/libcacard/vscclient.c
>> +++ b/libcacard/vscclient.c
>> @@ -11,6 +11,8 @@
>> */
>>
>> #ifndef _WIN32
>> +#include <sys/socket.h>
>> +#include <netinet/in.h>
>> #include <netdb.h>
>> #define closesocket(x) close(x)
>> #endif
>>
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Looks okay, CC'ing Alon and -trivial.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vscclient: Add required headers to fix build on FreeBSD
2014-06-18 15:22 ` Andreas Färber
@ 2014-06-20 20:38 ` Ed Maste
0 siblings, 0 replies; 5+ messages in thread
From: Ed Maste @ 2014-06-20 20:38 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Paolo Bonzini, Alon Levy, Andreas Färber
On 18 June 2014 11:22, Andreas Färber <afaerber@suse.de> wrote:
> Am 18.06.2014 16:41, schrieb Paolo Bonzini:
>> Il 18/06/2014 14:58, Ed Maste ha scritto:
>>> Signed-off-by: Ed Maste <emaste@freebsd.org>
>>> ---
>>> libcacard/vscclient.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
>>> index ab9b2b8..80111df 100644
>>> --- a/libcacard/vscclient.c
>>> +++ b/libcacard/vscclient.c
>>> @@ -11,6 +11,8 @@
>>> */
>>>
>>> #ifndef _WIN32
>>> +#include <sys/socket.h>
>>> +#include <netinet/in.h>
>>> #include <netdb.h>
>>> #define closesocket(x) close(x)
>>> #endif
>>>
>>
>> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Looks okay, CC'ing Alon and -trivial.
Ping - can we bring in this build fix other than by waiting on -trivial?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vscclient: Add required headers to fix build on FreeBSD
2014-06-18 12:58 [Qemu-devel] [PATCH] vscclient: Add required headers to fix build on FreeBSD Ed Maste
2014-06-18 14:41 ` Paolo Bonzini
@ 2014-06-21 12:48 ` Michael Tokarev
1 sibling, 0 replies; 5+ messages in thread
From: Michael Tokarev @ 2014-06-21 12:48 UTC (permalink / raw)
To: Ed Maste, qemu-devel
Applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-06-21 12:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-18 12:58 [Qemu-devel] [PATCH] vscclient: Add required headers to fix build on FreeBSD Ed Maste
2014-06-18 14:41 ` Paolo Bonzini
2014-06-18 15:22 ` Andreas Färber
2014-06-20 20:38 ` Ed Maste
2014-06-21 12:48 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).