From: Paolo Bonzini <pbonzini@redhat.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-stable@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-scsi: fix object check failure
Date: Wed, 18 Jun 2014 17:06:54 +0200 [thread overview]
Message-ID: <53A1AB0E.60906@redhat.com> (raw)
In-Reply-To: <53A1A9ED.5040500@redhat.com>
Il 18/06/2014 17:02, Paolo Bonzini ha scritto:
> Il 18/06/2014 16:18, Ming Lei ha scritto:
>>> > This should never be triggered by vhost-scsi. Perhaps a bug in the
>>> kernel?
>> It can be triggered with rmmod, system suspend, reboot...
>
> Yes, but it should not.
>
> What happens if you change VHOST_SCSI_VQ_NUM_FIXED from 2 to 3?
Sorry, brain fart here. The number of interrupts in virtio-scsi is
queues+3 because of the configuration interrupt. This does not apply here.
Anyway, vhost-scsi passes the number of virtqueues correctly to the kernel.
QEMU might be triggering this because, when vhost is stopped, the queue
is still not empty (as expected, since it's a receive queue).
Can you check that this is the case?
If so, patching QEMU is correct, but you need to change
VIRTIO_SCSI(vdev) to VIRTIO_SCSI_COMMON(vdev), and move events_dropped
from VirtIOSCSI to VirtIOSCSICommon.
Paolo
next prev parent reply other threads:[~2014-06-18 15:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 12:13 [Qemu-devel] [PATCH] virtio-scsi: fix object check failure Ming Lei
2014-06-18 12:29 ` Paolo Bonzini
2014-06-18 14:18 ` Ming Lei
2014-06-18 15:02 ` Paolo Bonzini
2014-06-18 15:06 ` Paolo Bonzini [this message]
2014-06-18 15:11 ` Ming Lei
2014-07-25 23:10 ` Nicholas A. Bellinger
2014-07-26 3:52 ` Ming Lei
2014-06-18 14:23 ` Andreas Färber
2014-06-18 14:43 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A1AB0E.60906@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@amazon.com \
--cc=ming.lei@canonical.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).