From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxHSP-0007zB-NY for qemu-devel@nongnu.org; Wed, 18 Jun 2014 11:07:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxHSG-0000k6-Nq for qemu-devel@nongnu.org; Wed, 18 Jun 2014 11:07:25 -0400 Sender: Paolo Bonzini Message-ID: <53A1AB0E.60906@redhat.com> Date: Wed, 18 Jun 2014 17:06:54 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1403093631-7384-1-git-send-email-ming.lei@canonical.com> <53A1860E.6040304@redhat.com> <53A1A9ED.5040500@redhat.com> In-Reply-To: <53A1A9ED.5040500@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-scsi: fix object check failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ming Lei Cc: Peter Maydell , "Michael S. Tsirkin" , qemu-stable@nongnu.org, Anthony Liguori , qemu-devel@nongnu.org Il 18/06/2014 17:02, Paolo Bonzini ha scritto: > Il 18/06/2014 16:18, Ming Lei ha scritto: >>> > This should never be triggered by vhost-scsi. Perhaps a bug in the >>> kernel? >> It can be triggered with rmmod, system suspend, reboot... > > Yes, but it should not. > > What happens if you change VHOST_SCSI_VQ_NUM_FIXED from 2 to 3? Sorry, brain fart here. The number of interrupts in virtio-scsi is queues+3 because of the configuration interrupt. This does not apply here. Anyway, vhost-scsi passes the number of virtqueues correctly to the kernel. QEMU might be triggering this because, when vhost is stopped, the queue is still not empty (as expected, since it's a receive queue). Can you check that this is the case? If so, patching QEMU is correct, but you need to change VIRTIO_SCSI(vdev) to VIRTIO_SCSI_COMMON(vdev), and move events_dropped from VirtIOSCSI to VirtIOSCSICommon. Paolo