From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34268)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WxHVK-0001jO-HB
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 11:10:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WxHVB-0002EL-9X
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 11:10:26 -0400
Received: from mail-wg0-x22f.google.com ([2a00:1450:400c:c00::22f]:57866)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WxHVB-0002Dd-3r
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 11:10:17 -0400
Received: by mail-wg0-f47.google.com with SMTP id k14so1007157wgh.30
	for <qemu-devel@nongnu.org>; Wed, 18 Jun 2014 08:10:15 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53A1ABD4.3000607@redhat.com>
Date: Wed, 18 Jun 2014 17:10:12 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <87vbs6qjhj.fsf_-_@blackfin.pond.sub.org>
	<5399CF09.8030803@6wind.com> <87ppidnqmy.fsf@blackfin.pond.sub.org>
	<539AC3E0.9090404@6wind.com> <539ACDE6.7020709@redhat.com>
	<539AFF7C.7090702@6wind.com> <539B064D.2050501@redhat.com>
	<CAJSP0QUcFGSGgQMjU=Ax3n6Gqx6h_ZZ1yXz6QgQiyYYe+e4K4w@mail.gmail.com>
	<53A00464.8090609@6wind.com> <53A00DEB.8030400@redhat.com>
	<20140618104849.GH14030@stefanha-thinkpad.redhat.com>
	<53A1A8BE.3000801@6wind.com>
In-Reply-To: <53A1A8BE.3000801@6wind.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Why I advise against using ivshmem
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Marchand <david.marchand@6wind.com>, Stefan Hajnoczi <stefanha@gmail.com>
Cc: Henning Schild <henning.schild@siemens.com>, Olivier MATZ <olivier.matz@6wind.com>, kvm <kvm@vger.kernel.org>, Claudio Fontana <claudio.fontana@huawei.com>, qemu-devel <qemu-devel@nongnu.org>, Linux Virtualization <virtualization@lists.linux-foundation.org>, Vincent JARDIN <vincent.jardin@6wind.com>, "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>

Il 18/06/2014 16:57, David Marchand ha scritto:
> Hello Stefan,
>
> On 06/18/2014 12:48 PM, Stefan Hajnoczi wrote:
>> One more thing to add to the list:
>>
>> static void ivshmem_read(void *opaque, const uint8_t * buf, int flags)
>>
>> The "flags" argument should be "size".  Size should be checked before
>> accessing buf.
>
> You are welcome to send a fix and I will review it.

This is not what a maintainer should do.  A maintainer should, if 
possible, contribute fixes to improve the code.

I know this is very different from usual "company-style" development 
(even open source software can be developed on with methods more typical 
of proprietary software), but we're asking you to do it because you 
evidently understand ivshmem better than us.

Claudio has more experience with free/open-source software.  Since he's 
interested in ivshmem, he can help you too.  Perhaps you could try 
sending out the patch, and Claudio can review it and send pull requests 
at least in the beginning?

Paolo