From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43818)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WxHzi-0001VR-FM
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 11:41:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WxHzb-0005UG-PU
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 11:41:50 -0400
Received: from cantor2.suse.de ([195.135.220.15]:55361 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WxHzb-0005U8-J6
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 11:41:43 -0400
Message-ID: <53A1B336.4090504@suse.de>
Date: Wed, 18 Jun 2014 17:41:42 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <20140613111703.22108.14322.stgit@bahia.local>
	<20140617073631.GL16768@stefanha-thinkpad.redhat.com>
	<539FF0E3.6040407@suse.de>
	<20140618103814.GG14030@stefanha-thinkpad.redhat.com>
	<CAFEAcA-N0QrFegG0RBCBh05ZWJJaYKLvUUnYDvR8uNArZp8btQ@mail.gmail.com>
	<20140618134204.GB31764@redhat.com>
	<20140618162804.6e2cb399@bahia.local>
	<CAFEAcA-jN_J2CwExMTsoRqgeCDUjcgL6vzSEBAxXhmj8GO8Q6A@mail.gmail.com>
	<53A1B248.7020007@suse.de>
	<CAFEAcA8adJS1PFpQF1N=itHenoLjbHTL0Dh18w3Fs6SDQpXbJA@mail.gmail.com>
In-Reply-To: <CAFEAcA8adJS1PFpQF1N=itHenoLjbHTL0Dh18w3Fs6SDQpXbJA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@amazon.com>, "Michael S. Tsirkin" <mst@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Rusty Russell <rusty@rustcorp.com.au>, QEMU Developers <qemu-devel@nongnu.org>, Juan Quintela <quintela@redhat.com>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>, Amit Shah <amit.shah@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Greg Kurz <gkurz@linux.vnet.ibm.com>


On 18.06.14 17:40, Peter Maydell wrote:
> On 18 June 2014 16:37, Alexander Graf <agraf@suse.de> wrote:
>> I actually agree with Greg here. We implicitly create different VGA adapters
>> today depending on TARGET_WORDS_BIGENDIAN. The FB endianness should have
>> been separate devices (BE / LE) or runtime configuration from the beginning.
>>
>> Anything that checks TARGET_WORDS_BIGENDIAN in hw/ is very likely to do
>> something pretty wrong ;).
> Directly, yes, it's a bit of a red flag. But a huge % of devices do
> indirectly, by marking their memory regions as DEVICE_NATIVE_ENDIAN.

That's ok and the expected ABI to devices. It's TARGET_WORDS_BIGENDIAN 
that's a good marker that something's wrong.


Alex