From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxICB-0006hs-JZ for qemu-devel@nongnu.org; Wed, 18 Jun 2014 11:54:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxIC5-00034x-Cc for qemu-devel@nongnu.org; Wed, 18 Jun 2014 11:54:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11226) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxIC5-00034i-4O for qemu-devel@nongnu.org; Wed, 18 Jun 2014 11:54:37 -0400 Message-ID: <53A1B627.7040202@redhat.com> Date: Wed, 18 Jun 2014 17:54:15 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1398876525-28831-1-git-send-email-ehabkost@redhat.com> <1398876525-28831-13-git-send-email-ehabkost@redhat.com> <53750D57.7010403@suse.de> <20140515191215.GU3302@otherpad.lan.raisama.net> <53A1B557.4020104@suse.de> In-Reply-To: <53A1B557.4020104@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 12/18] target-i386: Support check/enforce flags in TCG mode, too List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= , Eduardo Habkost Cc: Igor Mammedov , Marcelo Tosatti , qemu-devel@nongnu.org, Aurelien Jarno , Richard Henderson Il 18/06/2014 17:50, Andreas F=E4rber ha scritto: >>> >> + } else if (tcg_enabled()) { >>> >> return wi->tcg_features; >>> >> + } else { >>> >> + return UINT32_MAX; >> > >> > Agreed, but I would prefer writing it as ~0 instead of UINT32_MAX. > FTR done as ~0u to avoid any signedness issues. > FWIW, I find ~0u worse than ~0, because the former expands to 0xffffffff=20 if x86_cpu_get_supported_feature_word is ever changed to return=20 uint64_t. The latter instead returns all-ones as desired. Paolo