From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57580)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WxINA-0002fH-G4
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 12:06:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WxIN3-0000Rn-0k
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 12:06:04 -0400
Message-ID: <53A1B8DA.8010002@redhat.com>
Date: Wed, 18 Jun 2014 18:05:46 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1403105553-5478-1-git-send-email-ming.lei@canonical.com>	<20140618154335.GA25619@redhat.com>	<CACVXFVPz8s9xcbSiqv4u4_QTmT+Ynz1o9eUtf5Tm3iepfWBa4g@mail.gmail.com>	<53A1B5DF.7020303@redhat.com>
	<CACVXFVPYrZL4S-RMBuhNP16Xk4oHDCAGXso0NFod6ENwq1MbDg@mail.gmail.com>
In-Reply-To: <CACVXFVPYrZL4S-RMBuhNP16Xk4oHDCAGXso0NFod6ENwq1MbDg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1] virtio-scsi: fix object check failure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ming Lei <ming.lei@canonical.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-stable@nongnu.org, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, "Michael S. Tsirkin" <mst@redhat.com>

Il 18/06/2014 18:03, Ming Lei ha scritto:
>> >
>> > - initialize them to the existing functions in virtio_scsi_class_init
>> >
>> > - initialize them to dummy empty functions in vhost_scsi_class_init
> But vhost does need the three functions as vq's handle_out callback.

Yes, but they do not need to do anything, the kernel handles everything. 
  They just cannot be NULL.

Paolo