From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxMqn-0001ak-FD for qemu-devel@nongnu.org; Wed, 18 Jun 2014 16:53:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxMqi-0004tH-9S for qemu-devel@nongnu.org; Wed, 18 Jun 2014 16:52:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxMqh-0004tB-Vg for qemu-devel@nongnu.org; Wed, 18 Jun 2014 16:52:52 -0400 Message-ID: <53A1FC16.9090105@redhat.com> Date: Wed, 18 Jun 2014 14:52:38 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403121359-4275-1-git-send-email-ehabkost@redhat.com> <1403121359-4275-3-git-send-email-ehabkost@redhat.com> In-Reply-To: <1403121359-4275-3-git-send-email-ehabkost@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nhMvanDQkH7WIKPAxUVQCUrOPCGPlWqdu" Subject: Re: [Qemu-devel] [qom-cpu PATCH 2/3] target-i386: Remove unsupported bits from all CPU models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Igor Mammedov , kvm@vger.kernel.org, Aurelien Jarno , "Michael S. Tsirkin" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nhMvanDQkH7WIKPAxUVQCUrOPCGPlWqdu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/18/2014 01:55 PM, Eduardo Habkost wrote: > The following CPU features were never supported by neither TCG or KVM, > so they are useless on the CPU model definitions, today: >=20 The overall idea of this series makes sense to me (yes, I'd love to get libvirt to the point that we can use enforce mode), but I decline to review the actual contents (it's a bit over my head how all the models work) and leave it to the experts. But here's a trivial finding: > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 8de1566..2f32d29 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -680,10 +680,11 @@ static X86CPUDefinition builtin_x86_defs[] =3D { > .family =3D 16, > .model =3D 2, > .stepping =3D 3, > + /* MIssing: CPUID_HT */ s/MIssing/Missing/ --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nhMvanDQkH7WIKPAxUVQCUrOPCGPlWqdu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTofwWAAoJEKeha0olJ0NqmjQIAJQ3ASUkJcSnb2xA7uaJgzlo 8wXIPgjlfLyp8KznNyOKahFBnYssjm51MHp5SH+ZrBDT4hAe2NORl3rfzftCarLT afs0PZBkPUtPfQk4Ev2qJBV22GsDIHf0I9gWDfIK9ohUjWlKLOkzv04pOFRMdBv1 MBKW60MCLJfmSe7LtI5NxBeFio0dG5Og4kobz9dBH0YB6kDwQ8mp9JPklEXMFtDr I2C+YqvjiQxEsLqew5XL9Yf1xR5RtqwZ5ep2EtyP7lLljuZ9QqBaGNqZl7y75C8i VCUiG+Rm5RKuQeWyNWpLRfmSMd6ql6iA/X2X/Z1XQGQLt53gfClLguL/FLKm+k8= =KMga -----END PGP SIGNATURE----- --nhMvanDQkH7WIKPAxUVQCUrOPCGPlWqdu--