From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxThL-000819-Up for qemu-devel@nongnu.org; Thu, 19 Jun 2014 00:11:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxThG-00089L-SX for qemu-devel@nongnu.org; Thu, 19 Jun 2014 00:11:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxThG-00089H-JS for qemu-devel@nongnu.org; Thu, 19 Jun 2014 00:11:34 -0400 Message-ID: <53A262F3.3000202@redhat.com> Date: Wed, 18 Jun 2014 22:11:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403073840-32603-1-git-send-email-pbonzini@redhat.com> <1403073840-32603-24-git-send-email-pbonzini@redhat.com> In-Reply-To: <1403073840-32603-24-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QBepPfE2DvCn4dCmt3xRLP5qnbDiqWk0k" Subject: Re: [Qemu-devel] [PATCH 2.1 23/36] qapi event: convert other BLOCK_JOB events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: wenchaoqemu@gmail.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QBepPfE2DvCn4dCmt3xRLP5qnbDiqWk0k Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/18/2014 12:43 AM, Paolo Bonzini wrote: > From: Wenchao Xia >=20 > Since BLOCK_JOB_COMPLETED, BLOCK_JOB_CANCELLED, BLOCK_JOB_READY are > related, convert them in one patch. The block_job_event_* functions > are used to keep encapsulation of BlockJob structure. >=20 > Signed-off-by: Wenchao Xia > Signed-off-by: Paolo Bonzini > --- > +++ b/include/block/blockjob.h > @@ -217,12 +217,21 @@ void block_job_pause(BlockJob *job); > void block_job_resume(BlockJob *job); > =20 > /** > - * qobject_from_block_job: > + * block_job_event_cancle: s/cancle/cancel/ At this point, if you need to clean it up in a followup patch instead of delaying the series, I can live with it. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QBepPfE2DvCn4dCmt3xRLP5qnbDiqWk0k Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTomLzAAoJEKeha0olJ0NqkIgIAK9RbrHcmsZj6tyBKe1ZJGxO HnY+SuMRzsYz2/AI+UPkynbQIHwZYHq5Cyp3xRBg8zobwWNPyX2EOJhvTv5bahLI 8h3B26VKCeIe3nODkiOXnvSh3NQL/ySZmdALPAPFcEufy7J7O+26UG5lnSeMmeoY EwEtheKxzp59ECjVUxmCclaYGrzDPZ0JDy3kP/HuJ2/MJ52XGizyJDYNtU3WZwFy 2IslyGWn+0KRF5mq06ru64AZWOuaVytxlIAK06pp4/5XUYlmPbEB5Sf3ck8uiGKT xLyVVLtzuMjtN6kRk1wvzNRXbt1d0z93tjlxpyy8DdTqXhnimM4BkJwV+nH3BSQ= =3+wv -----END PGP SIGNATURE----- --QBepPfE2DvCn4dCmt3xRLP5qnbDiqWk0k--