From: Paolo Bonzini <pbonzini@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/3] nbd: Drop nbd_can_read()
Date: Thu, 19 Jun 2014 10:44:04 +0200 [thread overview]
Message-ID: <53A2A2D4.8040104@redhat.com> (raw)
In-Reply-To: <1403118403-14397-2-git-send-email-mreitz@redhat.com>
Il 18/06/2014 21:06, Max Reitz ha scritto:
> +static void nbd_set_handlers(NBDClient *client)
> +{
> + if (client->exp && client->exp->ctx) {
> + aio_set_fd_handler(client->exp->ctx, client->sock,
> + client->can_read ? nbd_read : NULL,
> + client->send_coroutine ? nbd_restart_write : NULL,
> + client);
> + }
> +}
Note that aio_set_fd_handler doesn't exist on Windows (yet), so this
patch breaks compilation on Windows. We can fix this for 2.2 and then
apply your patches.
Paolo
next prev parent reply other threads:[~2014-06-19 8:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 19:06 [Qemu-devel] [PATCH v2 0/3] nbd: Adapt for dataplane Max Reitz
2014-06-18 19:06 ` [Qemu-devel] [PATCH v2 1/3] nbd: Drop nbd_can_read() Max Reitz
2014-06-19 3:58 ` Stefan Hajnoczi
2014-06-20 17:04 ` Max Reitz
2014-06-19 8:44 ` Paolo Bonzini [this message]
2014-06-20 17:04 ` Max Reitz
2014-06-18 19:06 ` [Qemu-devel] [PATCH v2 2/3] block: Add AIO context notifiers Max Reitz
2014-06-19 4:01 ` Stefan Hajnoczi
2014-06-18 19:06 ` [Qemu-devel] [PATCH v2 3/3] nbd: Follow the BDS' AIO context Max Reitz
2014-06-19 4:01 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A2A2D4.8040104@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).