From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36252)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WxXxC-0001qn-4K
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 04:44:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WxXx5-0008Cu-NY
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 04:44:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:18710)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WxXx5-0008Cq-Fq
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 04:44:11 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5J8i9Ct022203
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 19 Jun 2014 04:44:09 -0400
Message-ID: <53A2A2D4.8040104@redhat.com>
Date: Thu, 19 Jun 2014 10:44:04 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1403118403-14397-1-git-send-email-mreitz@redhat.com>
	<1403118403-14397-2-git-send-email-mreitz@redhat.com>
In-Reply-To: <1403118403-14397-2-git-send-email-mreitz@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/3] nbd: Drop nbd_can_read()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

Il 18/06/2014 21:06, Max Reitz ha scritto:
> +static void nbd_set_handlers(NBDClient *client)
> +{
> +    if (client->exp && client->exp->ctx) {
> +        aio_set_fd_handler(client->exp->ctx, client->sock,
> +                           client->can_read ? nbd_read : NULL,
> +                           client->send_coroutine ? nbd_restart_write : NULL,
> +                           client);
> +    }
> +}


Note that aio_set_fd_handler doesn't exist on Windows (yet), so this 
patch breaks compilation on Windows.  We can fix this for 2.2 and then 
apply your patches.

Paolo