From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wxb4F-0003rz-K2 for qemu-devel@nongnu.org; Thu, 19 Jun 2014 08:03:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wxb47-0005Fn-7y for qemu-devel@nongnu.org; Thu, 19 Jun 2014 08:03:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wxb46-0005FW-Tz for qemu-devel@nongnu.org; Thu, 19 Jun 2014 08:03:39 -0400 Message-ID: <53A2D197.7040800@redhat.com> Date: Thu, 19 Jun 2014 06:03:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403073840-32603-1-git-send-email-pbonzini@redhat.com> <1403073840-32603-32-git-send-email-pbonzini@redhat.com> In-Reply-To: <1403073840-32603-32-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="993JmfhGKjwFHWtWRixiMx0djuFHaTXs0" Subject: Re: [Qemu-devel] [PATCH 2.1 31/36] qemu-char: introduce qemu_chr_alloc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: wenchaoqemu@gmail.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --993JmfhGKjwFHWtWRixiMx0djuFHaTXs0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/18/2014 12:43 AM, Paolo Bonzini wrote: > The next patch will modify this function to initialize state that is > common to all backends. >=20 > Reviewed-by: Fam Zheng > Signed-off-by: Paolo Bonzini > --- > backends/baum.c | 2 +- > backends/msmouse.c | 2 +- > include/sysemu/char.h | 9 +++++++++ > qemu-char.c | 32 +++++++++++++++++++------------- > spice-qemu-char.c | 2 +- > ui/console.c | 2 +- > 6 files changed, 32 insertions(+), 17 deletions(-) Missing hw/misc/ivshmem.c: static int pci_ivshmem_init(PCIDevice *dev) { =2E.. s->eventfd_chr =3D g_malloc0(s->vectors * sizeof(CharDriverState = *)); qemu_chr_add_handlers(s->server_chr, ivshmem_can_receive, ivshmem_read, ivshmem_event, s); Is that going to matter? If not, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --993JmfhGKjwFHWtWRixiMx0djuFHaTXs0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTotGYAAoJEKeha0olJ0NqfvYIAKYo234Z5UfEwixgZxs++8cG G8EcYJOP5YJWGGTNb7PAETvoWh3uujBax2Q5pdHKjVP4FnFRj0t3GZOiYpyp74z8 Om+EEtST0gMHkweIu/1W1KEbGIlfwtnXyCYblCgEABQ7dgra4A0hDrlDs2xQfnZD 1AF0PW/Jo1BpJFAHT5Y9Zyg6ZEAS9kE9li+a9KpMADz9ZzXQuYf4h98CZRh3JN5x syvBaQ3isEA+bkcttbiCVVuPwJqwxLEIGCBak9mVAHIHqWKvshzdGXxSiIbqQbYZ 9eoa0g5aZmjWQraYYn3S86LvsCtt8tzhXz6pSaITjrFSYC3Zmcuv+A22qSohYq8= =xzGY -----END PGP SIGNATURE----- --993JmfhGKjwFHWtWRixiMx0djuFHaTXs0--