From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51170)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WxbOZ-0001tc-P5
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 08:24:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WxbOO-00030a-IZ
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 08:24:47 -0400
Received: from cantor2.suse.de ([195.135.220.15]:45829 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WxbOO-00030W-CP
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 08:24:36 -0400
Message-ID: <53A2D682.1010903@suse.de>
Date: Thu, 19 Jun 2014 14:24:34 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1402992243-10224-1-git-send-email-arei.gonglei@huawei.com>
	<1403172316.22530.8.camel@nilsson.home.kraxel.org>
In-Reply-To: <1403172316.22530.8.camel@nilsson.home.kraxel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>, arei.gonglei@huawei.com
Cc: weidong.huang@huawei.com, luonengjun@huawei.com, qemu-devel@nongnu.org, stefanha@redhat.com, akong@redhat.com

Hi Gerd,

Am 19.06.2014 12:05, schrieb Gerd Hoffmann:
>> Gonglei (5):
>>   tests: add OHCI qtest
>>   tests: add UHCI qtest
>>   tests: add xHCI qtest
>>   usb-hcd-ehci-test: change ehci qtest more expansively
>>   usb-hcd-ehci-test: add ehci hotplug/unplug qtest
>=20
> I'd prefer to leave the usb-hcd-ehci-test alone.

Why? My idea was to put all EHCI testing code into that ehci file. This
is so that any defines or helper functions can be shared within the
file. Functional testing of the companion core should go into the
respective *hci file, unless there is some interaction to test.

Just because right now most test files are pretty empty doesn't mean
they need to stay that way.

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg