From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxbYE-0007nl-OB for qemu-devel@nongnu.org; Thu, 19 Jun 2014 08:34:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxbY8-0006RR-FE for qemu-devel@nongnu.org; Thu, 19 Jun 2014 08:34:46 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45965 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxbY8-0006RF-3l for qemu-devel@nongnu.org; Thu, 19 Jun 2014 08:34:40 -0400 Message-ID: <53A2D8DE.1080400@suse.de> Date: Thu, 19 Jun 2014 14:34:38 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1402992243-10224-1-git-send-email-arei.gonglei@huawei.com> <1402992243-10224-2-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1402992243-10224-2-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/5] tests: add OHCI qtest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: luonengjun@huawei.com, akong@redhat.com, weidong.huang@huawei.com, kraxel@redhat.com, stefanha@redhat.com Am 17.06.2014 10:03, schrieb arei.gonglei@huawei.com: > From: Gonglei >=20 > add ohci controller hotplug/unplug qtest >=20 > Signed-off-by: Gonglei > --- > MAINTAINERS | 2 +- > tests/Makefile | 3 +++ > tests/usb-hcd-ohci-test.c | 41 +++++++++++++++++++++++++++++++++++++++= ++ > 3 files changed, 45 insertions(+), 1 deletion(-) > create mode 100644 tests/usb-hcd-ohci-test.c >=20 > diff --git a/MAINTAINERS b/MAINTAINERS > index 51a6f51..2c81323 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -608,7 +608,7 @@ USB > M: Gerd Hoffmann > S: Maintained > F: hw/usb/* > -F: tests/usb-hcd-ehci-test.c > +F: tests/usb-hcd* usb-*-test.c? > =20 > VFIO > M: Alex Williamson > diff --git a/tests/Makefile b/tests/Makefile > index 361bb7b..b1fbfb6 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -151,6 +151,8 @@ check-qtest-i386-y +=3D tests/i82801b11-test$(EXESU= F) > gcov-files-i386-y +=3D hw/pci-bridge/i82801b11.c > check-qtest-i386-y +=3D tests/ioh3420-test$(EXESUF) > gcov-files-i386-y +=3D hw/pci-bridge/ioh3420.c > +check-qtest-i386-y +=3D tests/usb-hcd-ohci-test$(EXESUF) > +gcov-files-i386-y +=3D hw/usb/hcd-ohci.c > check-qtest-i386-y +=3D tests/usb-hcd-ehci-test$(EXESUF) > gcov-files-i386-y +=3D hw/usb/hcd-ehci.c > gcov-files-i386-y +=3D hw/usb/hcd-uhci.c > @@ -321,6 +323,7 @@ tests/ac97-test$(EXESUF): tests/ac97-test.o > tests/es1370-test$(EXESUF): tests/es1370-test.o > tests/intel-hda-test$(EXESUF): tests/intel-hda-test.o > tests/ioh3420-test$(EXESUF): tests/ioh3420-test.o > +tests/usb-hcd-ohci-test$(EXESUF): tests/usb-hcd-ohci-test.o > tests/usb-hcd-ehci-test$(EXESUF): tests/usb-hcd-ehci-test.o $(libqos-p= c-obj-y) > tests/qemu-iotests/socket_scm_helper$(EXESUF): tests/qemu-iotests/sock= et_scm_helper.o > tests/test-qemu-opts$(EXESUF): tests/test-qemu-opts.o libqemuutil.a li= bqemustub.a > diff --git a/tests/usb-hcd-ohci-test.c b/tests/usb-hcd-ohci-test.c > new file mode 100644 > index 0000000..bb54346 > --- /dev/null > +++ b/tests/usb-hcd-ohci-test.c > @@ -0,0 +1,41 @@ > +/* > + * QTest testcase for USB OHCI controller > + * > + * Copyright (c) 2014 HUAWEI TECHNOLOGIES CO.,LTD. > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or = later. > + * See the COPYING file in the top-level directory. > + */ > + > +#include > +#include > +#include "libqtest.h" > +#include "qemu/osdep.h" > + > + > +static void test_ohci_hotplug(void) > +{ > + qtest_start(""); > + > + /* hotplug an ohci controller */ > + qmp_exec_hmp_cmd("", "device_add pci-ohci,id=3Dohci"); > + > + /* hot unplug an ohci controller */ > + qmp_exec_hmp_cmd("", "device_del ohci"); Please use QMP for device_add/del, it's safer with regards to response parsing. > + > + qtest_end(); > +} > + > + > +int main(int argc, char **argv) > +{ > + int ret; > + > + g_test_init(&argc, &argv, NULL); > + > + qtest_add_func("/ohci/pci/ohci-hotplug", test_ohci_hotplug); Might it make sense to also include a traditional "cold-plug" test? It could be reused for ppc64 (sPAPR), where the q35 companion-controller snippet probably doesn't apply. > + > + ret =3D g_test_run(); > + > + return ret; > +} Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg