From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53818)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WxbbE-0001LO-C1
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 08:37:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Wxbb7-0007eL-1r
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 08:37:52 -0400
Received: from cantor2.suse.de ([195.135.220.15]:46001 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Wxbb6-0007eG-Rx
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 08:37:44 -0400
Message-ID: <53A2D996.4080706@suse.de>
Date: Thu, 19 Jun 2014 14:37:42 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1402992243-10224-1-git-send-email-arei.gonglei@huawei.com>
	<1402992243-10224-4-git-send-email-arei.gonglei@huawei.com>
In-Reply-To: <1402992243-10224-4-git-send-email-arei.gonglei@huawei.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 3/5] tests: add xHCI qtest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: luonengjun@huawei.com, akong@redhat.com, weidong.huang@huawei.com, kraxel@redhat.com, stefanha@redhat.com

Am 17.06.2014 10:04, schrieb arei.gonglei@huawei.com:
> From: Gonglei <arei.gonglei@huawei.com>
>=20
> add xhci controller hotplug/unplug qtest
>=20
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  tests/Makefile            |  3 +++
>  tests/usb-hcd-xhci-test.c | 42 +++++++++++++++++++++++++++++++++++++++=
+++
>  2 files changed, 45 insertions(+)
>  create mode 100644 tests/usb-hcd-xhci-test.c
>=20
> diff --git a/tests/Makefile b/tests/Makefile
> index 54b8af2..f13d229 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -155,6 +155,8 @@ check-qtest-i386-y +=3D tests/usb-hcd-ohci-test$(EX=
ESUF)
>  gcov-files-i386-y +=3D hw/usb/hcd-ohci.c
>  check-qtest-i386-y +=3D tests/usb-hcd-uhci-test$(EXESUF)
>  gcov-files-i386-y +=3D hw/usb/hcd-uhci.c
> +check-qtest-i386-y +=3D tests/usb-hcd-xhci-test$(EXESUF)
> +gcov-files-i386-y +=3D hw/usb/hcd-xhci.c
>  check-qtest-i386-y +=3D tests/usb-hcd-ehci-test$(EXESUF)
>  gcov-files-i386-y +=3D hw/usb/hcd-ehci.c
>  gcov-files-i386-y +=3D hw/usb/hcd-uhci.c
> @@ -327,6 +329,7 @@ tests/intel-hda-test$(EXESUF): tests/intel-hda-test=
.o
>  tests/ioh3420-test$(EXESUF): tests/ioh3420-test.o
>  tests/usb-hcd-ohci-test$(EXESUF): tests/usb-hcd-ohci-test.o
>  tests/usb-hcd-uhci-test$(EXESUF): tests/usb-hcd-uhci-test.o
> +tests/usb-hcd-xhci-test$(EXESUF): tests/usb-hcd-xhci-test.o
>  tests/usb-hcd-ehci-test$(EXESUF): tests/usb-hcd-ehci-test.o $(libqos-p=
c-obj-y)
>  tests/qemu-iotests/socket_scm_helper$(EXESUF): tests/qemu-iotests/sock=
et_scm_helper.o
>  tests/test-qemu-opts$(EXESUF): tests/test-qemu-opts.o libqemuutil.a li=
bqemustub.a

Nitpick: Maybe order xhci after ehci in both cases? Then we have 1.x /
2.0 / 3.0 ordering.

Same comments wrt QMP and -device testing apply.

Cheers,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg