From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxcTC-0002Sl-6t for qemu-devel@nongnu.org; Thu, 19 Jun 2014 09:33:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxcT5-0002t7-VE for qemu-devel@nongnu.org; Thu, 19 Jun 2014 09:33:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46825 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxcT5-0002pG-Oc for qemu-devel@nongnu.org; Thu, 19 Jun 2014 09:33:31 -0400 Message-ID: <53A2E6A8.8030704@suse.de> Date: Thu, 19 Jun 2014 15:33:28 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1402992243-10224-1-git-send-email-arei.gonglei@huawei.com> <1403172316.22530.8.camel@nilsson.home.kraxel.org> <53A2D682.1010903@suse.de> <1403182025.22530.13.camel@nilsson.home.kraxel.org> <53A2E084.5050708@suse.de> <33183CC9F5247A488A2544077AF1902086C0AF7C@SZXEMA503-MBS.china.huawei.com> In-Reply-To: <33183CC9F5247A488A2544077AF1902086C0AF7C@SZXEMA503-MBS.china.huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" Cc: "Huangweidong (C)" , Luonengjun , "qemu-devel@nongnu.org" , Gerd Hoffmann , "stefanha@redhat.com" , "akong@redhat.com" Hi Gonglei, Am 19.06.2014 15:19, schrieb Gonglei (Arei): >> -----Original Message----- >> From: Andreas F=C3=A4rber [mailto:afaerber@suse.de] >> Sent: Thursday, June 19, 2014 9:07 PM >> To: Gerd Hoffmann >> Cc: Gonglei (Arei); qemu-devel@nongnu.org; stefanha@redhat.com; >> eblake@redhat.com; akong@redhat.com; Huangweidong (C); Luonengjun >> Subject: Re: [PATCH 0/5] tests: add usb host adapter qtest cases >> >> Am 19.06.2014 14:47, schrieb Gerd Hoffmann: >>> Maybe it makes sense to have a usb-hcd-hotplug-test.c file and collec= t >>> hotplug testing for all usb hcds we have there. For code sharing >>> that'll be better for sure as the basic code flow is the same for all >>> hcd types. >> >> Ah yes, seeing that there is a "global" QEMU instance in 4/5, that may >> make more sense. >> > Hi, Gerd and Andreas, >=20 > Can we reach a consensus on this issue? IMO it does not make sense to create a new ehci-hotplug file that will only ever contain one test. Collecting all HCD hotplug tests into one hcd-hotplug file, as Gerd suggested, would be fine with me. We'll still need your hci-{ohci,uhci,xhci} files for functional (PCI/MMIO) tests and what I referred to as "cold-plug" or init testing though. >> OTOH hot-plug testing is a recurring topic for all PCI devices and won= 't >> work in general (e.g., virtio-blk needs drive),=20 > Yep. >=20 >> but maybe we can factor out some helpers to a .h file. >> > Such as... ? Can't tell what Gerd had in mind for hcd hotplug sharing, but I was thinking of some wrappers for the device_add and device_del commands. Not sure if that makes sense in practice. Probably best start without such a header and later we can see if there is much recurring code to be factored out. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg