From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wxcax-0000Qs-1a for qemu-devel@nongnu.org; Thu, 19 Jun 2014 09:41:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wxcas-0005Xl-4k for qemu-devel@nongnu.org; Thu, 19 Jun 2014 09:41:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wxcar-0005Xc-Jp for qemu-devel@nongnu.org; Thu, 19 Jun 2014 09:41:33 -0400 Message-ID: <53A2E889.5050503@redhat.com> Date: Thu, 19 Jun 2014 07:41:29 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403185072-24598-1-git-send-email-imammedo@redhat.com> In-Reply-To: <1403185072-24598-1-git-send-email-imammedo@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OIS3whtkHh46EA4Gj8G72AWs7qk8HVlGk" Subject: Re: [Qemu-devel] [PATCH] qapi/hmp: use 'backend' instead of 'device' with memory backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: hutao@cn.fujitsu.com, mst@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OIS3whtkHh46EA4Gj8G72AWs7qk8HVlGk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/19/2014 07:37 AM, Igor Mammedov wrote: > fixup documentation comments and HMP message/help text >=20 > Signed-off-by: Igor Mammedov > --- > PS: based on PCI tree > --- > hmp.c | 2 +- > monitor.c | 2 +- > qapi-schema.json | 11 ++++++----- > 3 files changed, 8 insertions(+), 7 deletions(-) >=20 > # Since: 2.1 > ## > { 'command': 'query-memdev', 'returns': ['Memdev'] } > + > # @PCDIMMDeviceInfo: Can you also add a ## lead-in to PCDIMMDeviceInfo? The rest of the file is fairly consistent at: ## # docs ## { ... } With that line added, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OIS3whtkHh46EA4Gj8G72AWs7qk8HVlGk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTouiKAAoJEKeha0olJ0NqT/gH/RAck4cRfpR9zVfDN882UaEZ SKsInTGXE/u7AEbCDYN/GD9UlzrI3x2QgOtHuGXeLdCO4ivEkpnDiHz3loM/k0um ZLMWjL4MEFRYwgyAYuDjSCRnSZo7BOmP7lz/X+dY4GuTg+ESoi0vB8ataDBIz+Ia RFjxMov+xB4CgfsMCOq5Y8cb/hiS5cVqzqDpYyXiW3TuxRRO1OFLprdMVntSCZuY 0ibYe3bdF8wRjOawgwPOROiSvE5wtDK3J0tlH+jU8S+TroeTp9QVxWgl2zIHF7Er 5F9bJySVDwgOXFSljtm1CoUYyMn6Ed6t3uASeVGPCZiKRgJOvP8Z0IJKbQjRLi4= =i1pG -----END PGP SIGNATURE----- --OIS3whtkHh46EA4Gj8G72AWs7qk8HVlGk--