From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40649)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Chris.Friesen@windriver.com>) id 1Wxe7f-0003pZ-LL
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 11:19:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Chris.Friesen@windriver.com>) id 1Wxe7V-000888-H3
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 11:19:31 -0400
Received: from mail.windriver.com ([147.11.1.11]:47281)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Chris.Friesen@windriver.com>) id 1Wxe7V-00087Z-9t
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 11:19:21 -0400
Message-ID: <53A2FF73.1080201@windriver.com>
Date: Thu, 19 Jun 2014 09:19:15 -0600
From: Chris Friesen <chris.friesen@windriver.com>
MIME-Version: 1.0
References: <53693FA4.3000306@windriver.com> <5369D504.2070101@redhat.com>
	<536AB2EE.6010504@windriver.com> <20140508130231.GA24978@grmbl.mre>
	<536B8332.9070705@redhat.com> <20140508133052.GA25602@grmbl.mre>
	<536B884D.6080504@redhat.com> <20140508134738.GB25602@grmbl.mre>
	<536BA579.10604@windriver.com> <536C2712.3030803@windriver.com>
	<536C8F7D.2050302@redhat.com>
In-Reply-To: <536C8F7D.2050302@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] virtio-serial-pci very expensive during live
	migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com

On 05/09/2014 02:19 AM, Paolo Bonzini wrote:
> Il 09/05/2014 02:53, Chris Friesen ha scritto:
>>
>>
>> Turns out I spoke too soon.  With the patch applied, it boots, but if I
>> try to do a live migration both the source and destination crash.  This
>> happens for both the master branch as well as the stable-1.4 branch.
>
> The destination doesn't crash, it simply stops because it got an
> incomplete migration stream.  Thanks for the report, the patch seems
> correct so it's worthwhile looking at it more closely.
>
>> If I back out the patch, it works fine.  If I leave the patch in and
>> disable kvm acceleration it works fine.
>
> Indeed, non-KVM doesn't use ioeventfd at all.

Did anyone ever figure out why wrapping the whole thing in 
memory_region_transaction_begin()/memory_region_transaction_commit() 
caused problems?

Chris