qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.a@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] hw/pcie: implement power controller functionality
Date: Thu, 19 Jun 2014 22:56:39 +0200	[thread overview]
Message-ID: <53A34E87.5020307@redhat.com> (raw)
In-Reply-To: <20140619143915.GA10359@redhat.com>

Il 19/06/2014 16:39, Michael S. Tsirkin ha scritto:
> >      pci_word_test_and_set_mask(dev->wmask + pos + PCI_EXP_SLTCTL,
> >                                 PCI_EXP_SLTCTL_PIC |
> > +                               PCI_EXP_SLTCTL_PCC |
> >                                 PCI_EXP_SLTCTL_AIC |
> >                                 PCI_EXP_SLTCTL_HPIE |
> >                                 PCI_EXP_SLTCTL_CCIE |
>
> Need to disable for compat types?

Do we support PCI-to-PCIe bridges?  Otherwise, AHCI breaks migration and 
the only PCIe machine always has an AHCI controller, so I'd say no.

Paolo

  reply	other threads:[~2014-06-19 20:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-19 13:52 [Qemu-devel] [PATCH 0/3] hw/pcie: better hotplug/hotunplug support Marcel Apfelbaum
2014-06-19 13:52 ` [Qemu-devel] [PATCH 1/3] hw/pcie: corrected a debug message Marcel Apfelbaum
2014-06-19 13:52 ` [Qemu-devel] [PATCH 2/3] hw/pcie: implement power controller functionality Marcel Apfelbaum
2014-06-19 14:39   ` Michael S. Tsirkin
2014-06-19 20:56     ` Paolo Bonzini [this message]
2014-06-22 10:47     ` Marcel Apfelbaum
2014-06-22 10:52       ` Michael S. Tsirkin
2014-06-22 11:11         ` Michael S. Tsirkin
2014-06-22 11:17           ` Marcel Apfelbaum
2014-06-19 13:52 ` [Qemu-devel] [PATCH 3/3] hw/pcie: better hotplug/hotunplug support Marcel Apfelbaum
2014-06-19 14:43   ` Michael S. Tsirkin
2014-06-22 10:54     ` Marcel Apfelbaum
2014-06-22 11:03       ` Michael S. Tsirkin
2014-06-22 11:11         ` Marcel Apfelbaum
2014-06-22 11:12           ` Michael S. Tsirkin
2014-06-22 11:24             ` Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A34E87.5020307@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=marcel.a@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).