From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxjO9-0000bv-T4 for qemu-devel@nongnu.org; Thu, 19 Jun 2014 16:57:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxjO0-0000TQ-KI for qemu-devel@nongnu.org; Thu, 19 Jun 2014 16:56:53 -0400 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:60334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxjO0-0000TE-EL for qemu-devel@nongnu.org; Thu, 19 Jun 2014 16:56:44 -0400 Received: by mail-wi0-f175.google.com with SMTP id r20so10020397wiv.2 for ; Thu, 19 Jun 2014 13:56:43 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53A34E87.5020307@redhat.com> Date: Thu, 19 Jun 2014 22:56:39 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1403185941-19561-1-git-send-email-marcel.a@redhat.com> <1403185941-19561-3-git-send-email-marcel.a@redhat.com> <20140619143915.GA10359@redhat.com> In-Reply-To: <20140619143915.GA10359@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] hw/pcie: implement power controller functionality List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Marcel Apfelbaum Cc: qemu-devel@nongnu.org Il 19/06/2014 16:39, Michael S. Tsirkin ha scritto: > > pci_word_test_and_set_mask(dev->wmask + pos + PCI_EXP_SLTCTL, > > PCI_EXP_SLTCTL_PIC | > > + PCI_EXP_SLTCTL_PCC | > > PCI_EXP_SLTCTL_AIC | > > PCI_EXP_SLTCTL_HPIE | > > PCI_EXP_SLTCTL_CCIE | > > Need to disable for compat types? Do we support PCI-to-PCIe bridges? Otherwise, AHCI breaks migration and the only PCIe machine always has an AHCI controller, so I'd say no. Paolo