From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53182)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wxu80-0007PG-WE
	for qemu-devel@nongnu.org; Fri, 20 Jun 2014 04:25:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wxu7t-0005uZ-0m
	for qemu-devel@nongnu.org; Fri, 20 Jun 2014 04:24:56 -0400
Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:36749)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wxu7s-0005u5-PU
	for qemu-devel@nongnu.org; Fri, 20 Jun 2014 04:24:48 -0400
Received: by mail-wi0-f178.google.com with SMTP id n15so358357wiw.11
	for <qemu-devel@nongnu.org>; Fri, 20 Jun 2014 01:24:47 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53A3EFCB.5090501@redhat.com>
Date: Fri, 20 Jun 2014 10:24:43 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20140613111703.22108.14322.stgit@bahia.local>
	<20140613112454.22108.70328.stgit@bahia.local>
In-Reply-To: <20140613112454.22108.70328.stgit@bahia.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v8 17/20] virtio-scsi: use virtio wrappers
	to access headers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@amazon.com>, Juan Quintela <quintela@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>, Alexander Graf <agraf@suse.de>, "Michael S. Tsirkin" <mst@redhat.com>, aneesh.kumar@linux.vnet.ibm.com, Stefan Hajnoczi <stefanha@redhat.com>, Amit Shah <amit.shah@redhat.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>

Il 13/06/2014 13:24, Greg Kurz ha scritto:
> From: Rusty Russell <rusty@rustcorp.com.au>
>
> Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
> [ pass VirtIODevice * to memory accessors,
>   fix missing tswap32 in virtio_scsi_push_event() by Cédric Le Goater,
>   Greg Kurz <gkurz@linux.vnet.ibm.com> ]
> Cc: Cédric Le Goater <clg@fr.ibm.com>

Be careful that, in the meanwhile, two tswap32s's have been added by 
commit b0b4ea1 (virtio-scsi: add target swap for VirtIOSCSICtrlTMFReq 
fields, 2014-06-10): one in virtio_scsi_do_tmf, one in 
virtio_scsi_handle_ctrl.

Paolo