From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49282)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WxyN7-0007lw-N2
	for qemu-devel@nongnu.org; Fri, 20 Jun 2014 08:56:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WxyN2-0000Wk-0F
	for qemu-devel@nongnu.org; Fri, 20 Jun 2014 08:56:49 -0400
Received: from cantor2.suse.de ([195.135.220.15]:35244 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WxyN1-0000WQ-QI
	for qemu-devel@nongnu.org; Fri, 20 Jun 2014 08:56:43 -0400
Message-ID: <53A42F89.6060503@suse.de>
Date: Fri, 20 Jun 2014 14:56:41 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1403259947-32233-1-git-send-email-james.hogan@imgtec.com>
	<20140620105837.GB12011@ohm.rr44.fr>
In-Reply-To: <20140620105837.GB12011@ohm.rr44.fr>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3] hw/mips: gt64xxx_pci: Add
	VMStateDescription
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>, James Hogan <james.hogan@imgtec.com>
Cc: Sanjay Lal <sanjayl@kymasys.com>, qemu-devel@nongnu.org

Am 20.06.2014 12:58, schrieb Aurelien Jarno:
> Thanks for this new version, I'll apply it in the next days unless
> someone comes with good arguments why we should not do that.
>=20
> Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

No objection to the code, I just think that "hw/mips:" is redundant in
the subject, although there's no precedent yet.
http://git.qemu-project.org/?p=3Dqemu.git;a=3Dhistory;f=3Dhw/mips/gt64xxx=
_pci.c;h=3D6398514c99d2b15cd047149c8457717e352e9347;hb=3DHEAD

Same applies to the other MIPS patch.

Cheers,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg